You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@age.apache.org by "MironAtHome (via GitHub)" <gi...@apache.org> on 2024/08/08 21:19:28 UTC
[I] get_graph_oid function declaration return type uint32 definition Oid [age]
MironAtHome opened a new issue, #2027:
URL: https://github.com/apache/age/issues/2027
**Describe the bug**
A clear and concise description of what the bug is.
Code bug.
Different declaration and definition of the function return parameter type
**How are you accessing AGE (Command line, driver, etc.)?**
N/A
**What data setup do we need to do?**
N/A
**What is the necessary configuration info needed?**
N/A
**What is the command that caused the error?**
N/A
**Expected behavior**
N/A
**Environment (please complete the following information):**
branches checked, master and PG16
**Additional context**
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] get_graph_oid function declaration return type uint32 definition Oid [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on issue #2027:
URL: https://github.com/apache/age/issues/2027#issuecomment-2285060299
@MironAtHome Just wanted to make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] get_graph_oid function declaration return type uint32 definition Oid [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on issue #2027:
URL: https://github.com/apache/age/issues/2027#issuecomment-2284745009
@MironAtHome If you are going to change the function return type, you need to verify that all locations that call it will not have an issue with that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] get_graph_oid function declaration return type uint32 definition Oid [age]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #2027:
URL: https://github.com/apache/age/issues/2027#issuecomment-2408254748
This issue is stale because it has been open 60 days with no activity. Remove "Abondoned" label or comment or this will be closed in 14 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] get_graph_oid function declaration return type uint32 definition Oid [age]
Posted by "MironAtHome (via GitHub)" <gi...@apache.org>.
MironAtHome commented on issue #2027:
URL: https://github.com/apache/age/issues/2027#issuecomment-2285022070
I did.
The good part is that it's only declaration that had uint32.
Function definition + all function calls ( I could find ) had return value declared as Oid.
I don't want to bias someone looking at the code as code reviewer, so read next few lines with a grain of salt.
When I looked over function calls, that is get_graph_oid function, all of the calls return to variable named graph_oid, all, save for one, where it's named "graph" and its type is declared as Oid, as well.
This is true for branches master, 12, 13, 14, 15 and 16, branch 11, for some reason, had type declared, as Oid in function declaration ( header file ).
In case I missed one or another ( and I checked a few times ), please add comment, I am happy to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] get_graph_oid function declaration return type uint32 definition Oid [age]
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed closed issue #2027: get_graph_oid function declaration return type uint32 definition Oid
URL: https://github.com/apache/age/issues/2027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org