You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/12 18:06:09 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #772:
nuttx: Fix the nightly build warning
xiaoxiang781216 opened a new pull request #772: nuttx: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx/pull/772
lpc2148_spi1.c:142:24: warning: initialization of 'uint32_t (*)(struct spi_dev_s *, uint32_t)' {aka 'unsigned int (*)(struct spi_dev_s *, unsigned int)'} from incompatible pointer type 'uint16_t (*)(struct spi_dev_s *, uint16_t)' {aka 'short unsigned int (*)(struct spi_dev_s *, short unsigned int)'} [-Wincompatible-pointer-types]
142 | .send = spi_send,
| ^~~~~~~~
lpc2148_spi1.c:142:24: note: (near initialization for 'g_spiops.send')
In file included from ieee802154/mac802154_bind.c:49:
ieee802154/mac802154_internal.h: In function 'mac802154_setdevmode':
ieee802154/mac802154_internal.h:788:42: warning: converting a packed 'enum ieee802154_devmode_e' pointer (alignment 1) to a 'const union ieee802154_attr_u' pointer (alignment 4) may result in an unaligned pointer value [-Waddress-of-packed-member]
788 | (FAR const union ieee802154_attr_u *)&mode);
| ^~~~~~~~~~~~~~~~~
chip/stm32_hciuart.c: In function 'hciuart_read':
chip/stm32_hciuart.c:2104:30: warning: statement with no effect [-Wunused-value]
2104 | ntotal == (ssize_t)ret;
| ~~~~~~~^~~~~~~~~~~~~~~
wireless/ieee80211/bcm43xxx/bcmf_driver.c: In function 'bcmf_wl_auth_event_handler':
wireless/ieee80211/bcm43xxx/bcmf_driver.c:579:23: warning: taking address of packed member of 'struct bcmf_event_s' may result in an unaligned pointer value [-Waddress-of-packed-member]
579 | type = bcmf_getle32(&event->type);
| ^~~~~~~~~~~~
wireless/ieee80211/bcm43xxx/bcmf_driver.c:580:25: warning: taking address of packed member of 'struct bcmf_event_s' may result in an unaligned pointer value [-Waddress-of-packed-member]
580 | status = bcmf_getle32(&event->status);
| ^~~~~~~~~~~~~~
wireless/ieee80211/bcm43xxx/bcmf_driver.c: In function 'bcmf_wl_scan_event_handler':
wireless/ieee80211/bcm43xxx/bcmf_driver.c:619:25: warning: taking address of packed member of 'struct bcmf_event_s' may result in an unaligned pointer value [-Waddress-of-packed-member]
619 | status = bcmf_getle32(&event->status);
| ^~~~~~~~~~~~~~
wireless/ieee80211/bcm43xxx/bcmf_driver.c:620:35: warning: taking address of packed member of 'struct bcmf_event_s' may result in an unaligned pointer value [-Waddress-of-packed-member]
620 | escan_result_len = bcmf_getle32(&event->len);
| ^~~~~~~~~~~
wireless/ieee80211/bcm43xxx/bcmf_bdc.c: In function 'bcmf_bdc_process_event_frame':
wireless/ieee80211/bcm43xxx/bcmf_bdc.c:166:27: warning: taking address of packed member of 'struct bcmf_event_s' may result in an unaligned pointer value [-Waddress-of-packed-member]
166 | event_id = bcmf_getle32(&event_msg->event.type);
| ^~~~~~~~~~~~~~~~~~~~~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c: In function 'sdio_io_rw_direct':
wireless/ieee80211/bcm43xxx/mmc_sdio.c:157:3: warning: converting a packed 'struct sdio_resp_R5' pointer (alignment 1) to a 'uint32_t' {aka 'unsigned int'} pointer (alignment 4) may result in an unaligned pointer value [-Waddress-of-packed-member]
157 | ret = SDIO_RECVR5(dev, SD_ACMD52, (uint32_t *)&resp);
| ^~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c:79:28: note: defined here
79 | begin_packed_struct struct sdio_resp_R5
| ^~~~~~~~~~~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c: In function 'sdio_io_rw_extended':
wireless/ieee80211/bcm43xxx/mmc_sdio.c:239:11: warning: converting a packed 'struct sdio_resp_R5' pointer (alignment 1) to a 'uint32_t' {aka 'unsigned int'} pointer (alignment 4) may result in an unaligned pointer value [-Waddress-of-packed-member]
239 | ret = SDIO_RECVR5(dev, SD_ACMD53, (uint32_t *)&resp);
| ^~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c:79:28: note: defined here
79 | begin_packed_struct struct sdio_resp_R5
| ^~~~~~~~~~~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c:244:11: warning: converting a packed 'struct sdio_resp_R5' pointer (alignment 1) to a 'uint32_t' {aka 'unsigned int'} pointer (alignment 4) may result in an unaligned pointer value [-Waddress-of-packed-member]
244 | ret = SDIO_RECVR5(dev, SD_ACMD53, (uint32_t *)&resp);
| ^~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c:79:28: note: defined here
79 | begin_packed_struct struct sdio_resp_R5
| ^~~~~~~~~~~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c:257:7: warning: converting a packed 'struct sdio_resp_R5' pointer (alignment 1) to a 'uint32_t' {aka 'unsigned int'} pointer (alignment 4) may result in an unaligned pointer value [-Waddress-of-packed-member]
257 | ret = SDIO_RECVR5(dev, SD_ACMD53, (uint32_t *)&resp);
| ^~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c:79:28: note: defined here
79 | begin_packed_struct struct sdio_resp_R5
| ^~~~~~~~~~~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c:265:3: warning: converting a packed 'struct sdio_resp_R5' pointer (alignment 1) to a 'uint32_t' {aka 'unsigned int'} pointer (alignment 4) may result in an unaligned pointer value [-Waddress-of-packed-member]
265 | SDIO_RECVR1(dev, SD_ACMD52ABRT, (uint32_t *)&resp);
| ^~~~~~~~~~~
wireless/ieee80211/bcm43xxx/mmc_sdio.c:79:28: note: defined here
79 | begin_packed_struct struct sdio_resp_R5
| ^~~~~~~~~~~~
chip/stm32_adc.c: In function 'adc_reset':
chip/stm32_adc.c:2860:7: warning: unused variable 'ret' [-Wunused-variable]
2860 | int ret;
| ^~~
chip/stm32_adc.c: In function 'adc_shutdown':
chip/stm32_adc.c:3044:7: warning: unused variable 'ret' [-Wunused-variable]
3044 | int ret;
| ^~~
chip/stm32_i2c.c:722:12: warning: 'stm32_i2c_sem_wait_noncancelable' defined but not used [-Wunused-function]
722 | static int stm32_i2c_sem_wait_noncancelable(FAR struct i2c_master_s *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
wireless/gs2200m.c: In function 'gs2200m_read':
wireless/gs2200m.c:727:20: warning: passing argument 1 of 'nxsem_wait' from incompatible pointer type [-Wincompatible-pointer-types]
727 | ret = nxsem_wait(dev);
| ^~~
| |
| struct gs2200m_dev_s *
.config:1207:warning: symbol value '' invalid for TESTING_OSTEST_FPUSIZE
platform/audio/cxd56_audio_analog.c:69:13: warning: inline function 'cxd56_audio_clock_is_enabled' declared but never defined
69 | inline bool cxd56_audio_clock_is_enabled(void);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
platform/audio/cxd56_audio_analog.c:68:13: warning: inline function 'cxd56_audio_clock_disable' declared but never defined
68 | inline void cxd56_audio_clock_disable(void);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
platform/audio/cxd56_audio_analog.c:67:13: warning: inline function 'cxd56_audio_clock_enable' declared but never defined
67 | inline void cxd56_audio_clock_enable(uint32_t clk, uint32_t div);
| ^~~~~~~~~~~~~~~~~~~~~~~~
chip/stm32_adc.c: In function 'adc_reset':
chip/stm32_adc.c:1348:7: warning: unused variable 'ret' [-Wunused-variable]
1348 | int ret;
| ^~~
chip/stm32_adc.c: In function 'adc_shutdown':
chip/stm32_adc.c:1496:7: warning: unused variable 'ret' [-Wunused-variable]
1496 | int ret;
| ^~~
chip/stm32_i2c.c:729:12: warning: 'stm32_i2c_sem_wait_uninterruptble' defined but not used [-Wunused-function]
729 | static int stm32_i2c_sem_wait_uninterruptble(FAR struct i2c_master_s *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
wireless/lpwan/sx127x/sx127x.c:147:52: warning: missing terminating ' character
147 | # warning OOK support is not complete, RX+TX doesn't work yet!
| ^
str71_spi.c:435:24: warning: initialization of 'uint32_t (*)(struct spi_dev_s *, uint32_t)' {aka 'unsigned int (*)(struct spi_dev_s *, unsigned int)'} from incompatible pointer type
'uint16_t (*)(struct spi_dev_s *, uint16_t)' {aka 'short unsigned int (*)(struct spi_dev_s *, short unsigned int)'} [-Wincompatible-pointer-types]
435 | .send = spi_send,
| ^~~~~~~~
str71_spi.c:435:24: note: (near initialization for 'g_spiops.send')
chip/pic32mx-lowconsole.c:147:24: warning: 'pic32mx_getreg' defined but not used [-Wunused-function]
static inline uint32_t pic32mx_getreg(uintptr_t uart_base,
^
chip/pic32mx-gpio.c:113:20: warning: 'pic32mx_value' defined but not used [-Wunused-function]
static inline bool pic32mx_value(uint16_t pinset)
^
chip/pic32mz-gpio.c:124:20: warning: 'pic32mz_value' defined but not used [-Wunused-function]
static inline bool pic32mz_value(pinset_t pinset)
^
chip/pic32mx-usbdev.c:3065:1: warning: 'pic32mx_epreserved' defined but not used [-Wunused-function]
pic32mx_epreserved(struct pic32mx_usbdev_s *priv, int epno)
^
mmcsd/mmcsd_spi.c: In function 'mmcsd_mediachanged':
mmcsd/mmcsd_spi.c:1938:7: warning: 'return' with a value, in function returning void
return ret;
^
In file included from partition/fs_partition.c:42:0:
partition/partition.h:66:19: warning: 'read_partition_block' defined but not used [-Wunused-function]
static inline int read_partition_block(FAR struct partition_state_s *state,
^
local/local_netpoll.c: In function 'local_pollsetup':
local/local_netpoll.c:305:1: warning: label 'pollerr' defined but not used [-Wunused-label]
pollerr:
^~~~~~~
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
Change-Id: If3ea8f32b878aa218072130f7c3018f0d3c1aca5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#772: nuttx: Fix the nightly build warning
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #772: nuttx: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx/pull/772#discussion_r407554097
##########
File path: arch/mips/src/pic32mx/pic32mx-usbdev.c
##########
@@ -2347,25 +2405,25 @@ static void pic32mx_ep0setup(struct pic32mx_usbdev_s *priv)
/* At this point, the request has been handled and there are three possible
* outcomes:
*
- * 1. The setup request was successfully handled above and a response packet
- * must be sent (may be a zero length packet).
+ * 1. The setup request was successfully handled above and a response
+ * packet must be sent (may be a zero length packet).
* 2. The request was successfully handled by the class implementation. In
- * case, the EP0 IN response has already been queued and the local variable
- * 'dispatched' will be set to true and ctrlstate != CTRLSTATE_STALL;
- * 3. An error was detected in either the above logic or by the class implementation
- * logic. In either case, priv->state will be set CTRLSTATE_STALL
- * to indicate this case.
+ * variable case, the EP0 IN response has already been queued and the
+ * local dispatched will be set to true and ctrlstate != CTRLSTATE_STALL
Review comment:
I this the word 'this' is missing beween "In case"
The word variable belongs on line 2412 after local
The single quotes around 'dispatched' are really necessary to make the sense readable. Otherwise, it looks like a word in the sentence, not a variable name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #772:
nuttx: Fix the nightly build warning
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #772: nuttx: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx/pull/772#discussion_r407463816
##########
File path: arch/mips/src/pic32mx/pic32mx-usbdev.c
##########
@@ -2347,25 +2405,25 @@ static void pic32mx_ep0setup(struct pic32mx_usbdev_s *priv)
/* At this point, the request has been handled and there are three possible
* outcomes:
*
- * 1. The setup request was successfully handled above and a response packet
- * must be sent (may be a zero length packet).
+ * 1. The setup request was successfully handled above and a response
+ * packet must be sent (may be a zero length packet).
* 2. The request was successfully handled by the class implementation. In
- * case, the EP0 IN response has already been queued and the local variable
- * 'dispatched' will be set to true and ctrlstate != CTRLSTATE_STALL;
- * 3. An error was detected in either the above logic or by the class implementation
- * logic. In either case, priv->state will be set CTRLSTATE_STALL
- * to indicate this case.
+ * variable case, the EP0 IN response has already been queued and the
+ * local dispatched will be set to true and ctrlstate != CTRLSTATE_STALL
Review comment:
this change looks wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#772: nuttx: Fix the nightly build warning
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #772: nuttx: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx/pull/772#discussion_r407554097
##########
File path: arch/mips/src/pic32mx/pic32mx-usbdev.c
##########
@@ -2347,25 +2405,25 @@ static void pic32mx_ep0setup(struct pic32mx_usbdev_s *priv)
/* At this point, the request has been handled and there are three possible
* outcomes:
*
- * 1. The setup request was successfully handled above and a response packet
- * must be sent (may be a zero length packet).
+ * 1. The setup request was successfully handled above and a response
+ * packet must be sent (may be a zero length packet).
* 2. The request was successfully handled by the class implementation. In
- * case, the EP0 IN response has already been queued and the local variable
- * 'dispatched' will be set to true and ctrlstate != CTRLSTATE_STALL;
- * 3. An error was detected in either the above logic or by the class implementation
- * logic. In either case, priv->state will be set CTRLSTATE_STALL
- * to indicate this case.
+ * variable case, the EP0 IN response has already been queued and the
+ * local dispatched will be set to true and ctrlstate != CTRLSTATE_STALL
Review comment:
The word 'this' is missing beween "In case"
The word variable belongs on line 2412 after local
The single quotes around 'dispatched' are really necessary to make the sense readable. Otherwise, it looks like a word in the sentence, not a variable name. ctrlstate does not have this confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #772: nuttx: Fix
the nightly build warning
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #772: nuttx: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx/pull/772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #772: nuttx: Fix the nightly build warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #772: nuttx: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx/pull/772#discussion_r407584983
##########
File path: arch/mips/src/pic32mx/pic32mx-usbdev.c
##########
@@ -2347,25 +2405,25 @@ static void pic32mx_ep0setup(struct pic32mx_usbdev_s *priv)
/* At this point, the request has been handled and there are three possible
* outcomes:
*
- * 1. The setup request was successfully handled above and a response packet
- * must be sent (may be a zero length packet).
+ * 1. The setup request was successfully handled above and a response
+ * packet must be sent (may be a zero length packet).
* 2. The request was successfully handled by the class implementation. In
- * case, the EP0 IN response has already been queued and the local variable
- * 'dispatched' will be set to true and ctrlstate != CTRLSTATE_STALL;
- * 3. An error was detected in either the above logic or by the class implementation
- * logic. In either case, priv->state will be set CTRLSTATE_STALL
- * to indicate this case.
+ * variable case, the EP0 IN response has already been queued and the
+ * local dispatched will be set to true and ctrlstate != CTRLSTATE_STALL
Review comment:
Yes, I move variable to the wrong location, I will provide a patch fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #772: nuttx: Fix the nightly build warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #772: nuttx: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx/pull/772#discussion_r407590397
##########
File path: arch/mips/src/pic32mx/pic32mx-usbdev.c
##########
@@ -2347,25 +2405,25 @@ static void pic32mx_ep0setup(struct pic32mx_usbdev_s *priv)
/* At this point, the request has been handled and there are three possible
* outcomes:
*
- * 1. The setup request was successfully handled above and a response packet
- * must be sent (may be a zero length packet).
+ * 1. The setup request was successfully handled above and a response
+ * packet must be sent (may be a zero length packet).
* 2. The request was successfully handled by the class implementation. In
- * case, the EP0 IN response has already been queued and the local variable
- * 'dispatched' will be set to true and ctrlstate != CTRLSTATE_STALL;
- * 3. An error was detected in either the above logic or by the class implementation
- * logic. In either case, priv->state will be set CTRLSTATE_STALL
- * to indicate this case.
+ * variable case, the EP0 IN response has already been queued and the
+ * local dispatched will be set to true and ctrlstate != CTRLSTATE_STALL
Review comment:
@yamt and @papatience done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services