You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/21 11:16:02 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4575: net/devif: Simplify the logic in the error path of devif_callback_alloc

xiaoxiang781216 edited a comment on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-923880880


   > Seems OK to me on the surface.
   > 
   > The function's docstring says assumptions: this function is called with the network locked. Is that a stale comment?
   
   @hartmannathan after search all the invocation place, the comment is correct, but the code is too conservative. Do you want to remove the lock/unlock? I can provide a patch for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org