You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "hdygxsj (via GitHub)" <gi...@apache.org> on 2023/11/27 14:31:05 UTC
[PR] cdc job definition persistence [incubator-paimon-webui]
hdygxsj opened a new pull request, #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
Completed CRUD for CDC job definition
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Suport CDC job definition persistence [incubator-paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas merged PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "labbomb (via GitHub)" <gi...@apache.org>.
labbomb commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1426114513
##########
paimon-web-ui-new/src/api/models/cdc/index.ts:
##########
@@ -0,0 +1,42 @@
+/* Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License. */
+
+
+import type { CdcJobDefinition } from './interface'
+import httpRequest from '@/api/request'
+export * from './interface'
+
+
Review Comment:
Please add a description of each interface, refer to catlog
##########
paimon-web-ui-new/src/form-lib/cdc/use-paimon.ts:
##########
@@ -15,83 +15,50 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License. */
+import { getAllCatalogs } from "@/api/models/catalog"
import type { IJsonItem } from "@/components/dynamic-form/types"
-export function usePaimon(item:any) {
- const { t } = useLocaleHooks()
-
- const tabType = item.data.tabType
- console.log('item', item.data)
-
+export function usePaimon(item: any) {
+ const { t } = useLocaleHooks()
+ const tabType = item.data.tabType
+ let catalogOptions: any = ref([{value:1}])
+ getAllCatalogs().then((res: any) => {
+ catalogOptions.value = res.data.map((e: any) => { return { value: e.id, label: e.catalogName } })
+ })
+ console.log('item', item.data)
Review Comment:
Delete this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#issuecomment-1837890670
LGTM, @SteNicholas @JingsongLi @labbomb PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "hdygxsj (via GitHub)" <gi...@apache.org>.
hdygxsj commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1411673156
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/CdcJobDefinition.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.data.model;
+
+import com.baomidou.mybatisplus.annotation.TableLogic;
+import com.baomidou.mybatisplus.annotation.TableName;
+import lombok.AllArgsConstructor;
+import lombok.Builder;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.NoArgsConstructor;
+
+import java.io.Serializable;
+
+/** @TableName cdc_job_definition */
Review Comment:
done
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/dto/CdcJobDefinitionDTO.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.data.dto;
+
+import lombok.Data;
+
+@Data
+public class CdcJobDefinitionDTO {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "zhangmo8 (via GitHub)" <gi...@apache.org>.
zhangmo8 commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1426762147
##########
paimon-web-ui-new/src/views/metadata/components/menu-tree/index.tsx:
##########
@@ -120,7 +120,7 @@ export default defineComponent({
<n-space justify='space-between' align='enter'>
<article>Catalog</article>
<n-button size='small' quaternary circle>
- <n-icon>
+ <n-icon >
Review Comment:
What's this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "labbomb (via GitHub)" <gi...@apache.org>.
labbomb commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1426203865
##########
paimon-web-ui-new/src/views/cdc/index.tsx:
##########
@@ -21,12 +21,12 @@ import styles from './index.module.scss';
import { Leaf } from '@vicons/ionicons5';
import { useCDCStore } from '@/store/cdc';
import type { Router } from 'vue-router';
-
+import { useMessage } from 'naive-ui'
export default defineComponent({
name: 'CDCPage',
setup() {
const { t } = useLocaleHooks()
-
+ window.$message = useMessage()
Review Comment:
Why mount useMessage in window
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1408627495
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/dto/CdcJobDefinitionDTO.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.data.dto;
+
+import lombok.Data;
+
+@Data
+public class CdcJobDefinitionDTO {
Review Comment:
Please add java doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "hdygxsj (via GitHub)" <gi...@apache.org>.
hdygxsj commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1426771496
##########
paimon-web-ui-new/src/views/metadata/components/menu-tree/index.tsx:
##########
@@ -120,7 +120,7 @@ export default defineComponent({
<n-space justify='space-between' align='enter'>
<article>Catalog</article>
<n-button size='small' quaternary circle>
- <n-icon>
+ <n-icon >
Review Comment:
I added it by accident. It's been deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1407001056
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/CdcJobDefinitionController.java:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.controller;
+
+import org.apache.paimon.web.server.data.dto.CdcJobDefinitionDTO;
+import org.apache.paimon.web.server.data.model.CdcJobDefinition;
+import org.apache.paimon.web.server.data.result.PageR;
+import org.apache.paimon.web.server.data.result.R;
+import org.apache.paimon.web.server.service.CdcJobDefinitionService;
+
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.web.bind.annotation.*;
+
+@Slf4j
Review Comment:
Please add java doc.
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/mapper/CdcJobDefinitionMapper.java:
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.mapper;
+
+import org.apache.paimon.web.server.data.model.CdcJobDefinition;
+
+import com.baomidou.mybatisplus.core.mapper.BaseMapper;
+
+/**
+ * @author zhongyangyang
+ * @description 针对表【cdc_job_definition】的数据库操作Mapper
Review Comment:
Please use English comments and do not need to include author information.
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/dto/CdcJobDefinitionDTO.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.data.dto;
+
+import lombok.Data;
+
Review Comment:
Class header add java doc.
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/CdcJobDefinitionServiceImpl.java:
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.service.impl;
+
+import org.apache.paimon.web.server.data.dto.CdcJobDefinitionDTO;
+import org.apache.paimon.web.server.data.model.CdcJobDefinition;
+import org.apache.paimon.web.server.data.result.PageR;
+import org.apache.paimon.web.server.data.result.R;
+import org.apache.paimon.web.server.data.result.enums.Status;
+import org.apache.paimon.web.server.mapper.CdcJobDefinitionMapper;
+import org.apache.paimon.web.server.service.CdcJobDefinitionService;
+
+import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
+import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
+import com.baomidou.mybatisplus.extension.service.impl.ServiceImpl;
+import org.springframework.stereotype.Service;
+
+/** @author zhongyangyang */
Review Comment:
ditto
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/service/CdcJobDefinitionService.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.service;
+
+import org.apache.paimon.web.server.data.dto.CdcJobDefinitionDTO;
+import org.apache.paimon.web.server.data.model.CdcJobDefinition;
+import org.apache.paimon.web.server.data.result.PageR;
+import org.apache.paimon.web.server.data.result.R;
+
+import com.baomidou.mybatisplus.extension.service.IService;
+
+/** @author zhongyangyang */
Review Comment:
ditto
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/CdcJobDefinition.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.data.model;
+
+import com.baomidou.mybatisplus.annotation.TableLogic;
+import com.baomidou.mybatisplus.annotation.TableName;
+import lombok.*;
+
+import java.io.Serializable;
+
+/** @TableName cdc_job_definition */
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1408650352
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/CdcJobDefinition.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.web.server.data.model;
+
+import com.baomidou.mybatisplus.annotation.TableLogic;
+import com.baomidou.mybatisplus.annotation.TableName;
+import lombok.AllArgsConstructor;
+import lombok.Builder;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.NoArgsConstructor;
+
+import java.io.Serializable;
+
+/** @TableName cdc_job_definition */
Review Comment:
CdcJobDefinition entity class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "hdygxsj (via GitHub)" <gi...@apache.org>.
hdygxsj commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1426753211
##########
paimon-web-ui-new/src/views/cdc/index.tsx:
##########
@@ -21,12 +21,12 @@ import styles from './index.module.scss';
import { Leaf } from '@vicons/ionicons5';
import { useCDCStore } from '@/store/cdc';
import type { Router } from 'vue-router';
-
+import { useMessage } from 'naive-ui'
export default defineComponent({
name: 'CDCPage',
setup() {
const { t } = useLocaleHooks()
-
+ window.$message = useMessage()
Review Comment:
call useMessage() in request.ts will get undefined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] cdc job definition persistence [incubator-paimon-webui]
Posted by "zhangmo8 (via GitHub)" <gi...@apache.org>.
zhangmo8 commented on code in PR #99:
URL: https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1426211633
##########
paimon-web-ui-new/src/views/cdc/components/list/index.tsx:
##########
@@ -15,229 +15,17 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License. */
+import { NDataTable, NPagination, NSpace } from 'naive-ui';
Review Comment:
remove import
##########
paimon-web-ui-new/src/views/cdc/components/list/index.tsx:
##########
@@ -247,12 +35,24 @@ export default defineComponent({
render() {
return (
<div class={styles['list-page']}>
- <n-data-table
- columns={this.columns}
- data={this.data}
- pagination={this.pagination}
- bordered={false}
- />
+ <NSpace vertical>
+ <NDataTable
+ columns={this.columns}
+ data={this.data}
+ />
+ <NSpace justify='center'>
+ <NPagination
+ v-model:page={this.pagination.page}
+ v-model:page-size={this.pagination.pageSize}
+ item-count={this.pagination.count}
+ show-size-picker
+ page-sizes={this.pagination.pageSizes}
+ show-quick-jumper
+ onUpdatePage={this.pagination.onChange}
+ onUpdatePageSize={this.pagination.onUpdatePageSize}
+ />
+ </NSpace>
+ </NSpace>
Review Comment:
These components can be automatically imported by `n-space` and do not need to be imported by yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org