You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/09 03:43:20 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1254: Modify telnetd

xiaoxiang781216 commented on PR #1254:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1208875452

   > @xiaoxiang781216 Could you review this PR again?
   
   Let's summary my proposal:
   
   1. Move examples/telnetd to system/telnetd
   2. Change telnetd_start to telnetd_run
       a. Remove task_create in telnetd_start
       b. Reuse the caller(telnetd) thread do the real work
   3. Replace telnetd_start in nsh to nsh_execute("telnetd"...)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org