You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/11/05 01:35:25 UTC
Review Request 15221: Moved GroupProcess into group.hpp and made it a public
member of Group for testing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15221/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/zookeeper/group.hpp 6b6c1557658df1bb7b7df3ded5c203e2dc0c8308
src/zookeeper/group.cpp cd58d230a2715b9ed01002443ebd7b5366d31be6
Diff: https://reviews.apache.org/r/15221/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request 15221: Moved GroupProcess into group.hpp and made it a
public member of Group for testing.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15221/#review28159
-----------------------------------------------------------
Ship it!
src/zookeeper/group.hpp
<https://reviews.apache.org/r/15221/#comment54768>
Looks like this one can be forward declared instead of included?
src/zookeeper/group.hpp
<https://reviews.apache.org/r/15221/#comment54770>
Ditto?
- Ben Mahler
On Nov. 5, 2013, 12:35 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15221/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 12:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/zookeeper/group.hpp 6b6c1557658df1bb7b7df3ded5c203e2dc0c8308
> src/zookeeper/group.cpp cd58d230a2715b9ed01002443ebd7b5366d31be6
>
> Diff: https://reviews.apache.org/r/15221/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 15221: Moved GroupProcess into group.hpp and made it a
public member of Group for testing.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15221/
-----------------------------------------------------------
(Updated Nov. 5, 2013, 10:10 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
BenM's
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/zookeeper/group.hpp 6b6c1557658df1bb7b7df3ded5c203e2dc0c8308
src/zookeeper/group.cpp cd58d230a2715b9ed01002443ebd7b5366d31be6
Diff: https://reviews.apache.org/r/15221/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu