You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2022/01/06 07:52:59 UTC

[GitHub] [opennlp] jonmv commented on pull request #399: OPENNLP-1350 Improve normaliser MAIL_REGEX

jonmv commented on pull request #399:
URL: https://github.com/apache/opennlp/pull/399#issuecomment-1006353294


   Hi, the unit tests do not need to be updated. They were valid before, and still are. This is primarily a performance optimisation. Additionally, the PR allows `+` in the local-part of emails, and disallows `_` in the domain part. This is just an improvement. The actual email local-part rules are terrifying, and probably not worth expressing in a regex—the current is a compromise which should capture common email addresses out there. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org