You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "massakam (via GitHub)" <gi...@apache.org> on 2023/03/03 05:41:08 UTC
[GitHub] [pulsar-client-node] massakam opened a new pull request, #302: [fix] Fix error when falling back to local build
massakam opened a new pull request, #302:
URL: https://github.com/apache/pulsar-client-node/pull/302
### Motivation
If fetching pre-built binaries from a remote server fails, node-pre-gyp will try to fallback to building locally. However, even if the Pulsar C++ library is installed locally, this build does not succeed. This is because the C++ library must have been downloaded by a script under the `pkg` directory in this repository. Normal users other than Pulsar developers do not do this.
```sh
$ npm i pulsar-client-1.9.0-rc.0.tgz
...
npm ERR! g++: error: ../pkg/linux/pulsar-cpp/lib/libpulsarwithdeps.a: No such file or directory
```
### Modifications
Fixed `binding.gyp` to try to link to shared libraries installed by package managers such as Homebrew, RPM and APT if no C++ libraries are downloaded under the `pkg` directory.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Documentation
- [ ] `doc-required`
- [ ] `doc-not-needed`
- [ ] `doc`
- [ ] `doc-complete`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] shibd merged pull request #302: [fix] Fix error when falling back to local build
Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd merged PR #302:
URL: https://github.com/apache/pulsar-client-node/pull/302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] massakam commented on pull request #302: [fix] Fix error when falling back to local build
Posted by "massakam (via GitHub)" <gi...@apache.org>.
massakam commented on PR #302:
URL: https://github.com/apache/pulsar-client-node/pull/302#issuecomment-1453259791
@shibd
> If this PR is merged, this behavior will be changed. If you install `1.9.0-rc.1` (not yet released), the local cpp client version is 2.8.0 (old), and the build may fail.
Hmm, I don't quite understand your concerns... Currently, that build always fails if there is no C++ library under the `pkg` directory, right? When this PR is merged, if there is a library under `pkg` it will be used, otherwise the library installed on the local machine will be used. If the installed library version is high enough, it will succeed. In other words, it increases the chances of a successful build.
Are you concerned that the version of the installed C++ library is not the expected one, resulting in successful compilation but unexpected behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] shibd commented on pull request #302: [fix] Fix error when falling back to local build
Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on PR #302:
URL: https://github.com/apache/pulsar-client-node/pull/302#issuecomment-1453511728
> Are you concerned that the version of the installed C++ library is not the expected one, resulting in successful compilation but unexpected behavior?
Yes, That's precisely what I'm worried about.
I thought for a moment. The PR is a fix for the developer experience. For developers, we should ensure that the locally installed CPP client is matched.
So, I remove my request change. Thanks for your contribute!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org