You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pdion891 <gi...@git.apache.org> on 2015/07/26 15:45:36 UTC
[GitHub] cloudstack pull request: initial dockerization commit.
GitHub user pdion891 opened a pull request:
https://github.com/apache/cloudstack/pull/623
initial dockerization commit.
Initial PR for Dockerization of CloudStack.
Important Changes:
* scripts/vm/systemvm/injectkeys.sh: script execution will pass event if /dev/loop0 not detected and will skip verification of sshkey, this is a limiation in Docker container.
* Dockerfile for simulator move into /tools/docker: Need to change Jenkins jobs and Dockerhub build after the merge.
Current docker file working:
* simulator (Seb's original file)
* management-server on centos6 (using RPM's)
* marvin
comments from PR #605 corrected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdion891/cloudstack dockerfile2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/623.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #623
----
commit e4b2929743be35c47445e3a59c7ed4b0a0fa65c6
Author: Pierre-Luc Dion <pd...@apache.org>
Date: 2015-07-26T13:33:14Z
initial dockerization commit.
1. update injectkeys.sh to work into restricted container
2. move previous dockerfiles into tools/docker
3. dockerfiles for management-server on centos and marvin
CLOUDSTACK-8249
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: initial dockerization commit.
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/623#issuecomment-126909038
@karuturi , I haven't found a way to specify the release number at the ```docker build```. If there is a way I would use it so Dockerfiles would be same across branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: initial dockerization commit.
Posted by Pierre-Luc Dion <pd...@apache.org>.
Hello dev@!
I'm looking for another LGTM (real one, please read the PR) as replacement
of Seb, PR #623 replace the PR #605 based on Seb's comments.
Cheers,
On Mon, Jul 27, 2015 at 4:52 AM, wido <gi...@git.apache.org> wrote:
> Github user wido commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/623#issuecomment-125132961
>
> LGTM
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: initial dockerization commit.
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/623#issuecomment-125132961
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: initial dockerization commit.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/623
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: initial dockerization commit.
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/623#issuecomment-126582144
I was able to build the images locally. changes looks good. :+1:
for the centos 6 and marvin, it is always taking 4.6 images from jenkins. Which means we have to change this file for every release. Is there a way to get the current working release and probably release -1? If we could tag the master as latest and release-1 with the release number, that would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---