[jira] [Commented] (HADOOP-15546) ABFS: tune imports & javadocs

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531927#comment-16531927 ] 

Steve Loughran commented on HADOOP-15546:
-----------------------------------------

Patch 002
* rebased onto the current HADOOP-15407 branch
* review some more files; fix up log statements & a few IDE hints. 
* for {{AbfsOutputStream}}, try to keep exceptions as detailed as possible, in type and in inner causes
 look @ some tests. 
* For AbfsClient I moved to static imports of all the constants, which keeps the code tighter, though it could be argued keeping those refs is a good thing.

Testing. I haven't got the abfs tests to work yet. HADOOP-15579 still exists; if I bypass that then tests are skipping, which makes me concluded that some assume() are getting in the way. 

I think I'm going to have to look at the test setup next. I'd like just to move them all to use the contract test setup; if not, at least use ContractTestUtils for all their FS operations and assertions, both for less code and for useful info on failure. There's not enough diagnostics right now to begin to help any misconfigured user to get started in diagnosing what's up. Which is where I'm stuck right now.

> ABFS: tune imports & javadocs
> -----------------------------
>
>                 Key: HADOOP-15546
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15546
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: HADOOP-15407
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>         Attachments: HADOOP-15546-001.patch, HADOOP-15546-HADOOP-15407-001.patch, HADOOP-15546-HADOOP-15407-002.patch
>
>
> Followup on HADOOP-15540 with some initial review tuning
> * ordering of imports
> * rely on azure-auth-keys.xml to store credentials (change imports, docs,.gitignore)
> * log4j -> info
> * add a "." to the first sentence of all the javadocs I noticed.
> * remove @Public annotations except for some constants (which includes some commitment to maintain them).
> * move the AbstractFS declarations out of the src/test/resources XML file into core-default.xml for all to use
> * other IDE-suggested tweaks
> No actual code changes here; just setting things up better for >1 person editing & testing



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org