You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/24 13:03:52 UTC
[GitHub] [kafka] ijuma opened a new pull request #10394: MINOR: Always apply the java-library plugin
ijuma opened a new pull request #10394:
URL: https://github.com/apache/kafka/pull/10394
As @chia7712 found, we applied the `java` plugin indirectly via `rat.gradle`
if the `.git` folder exists (https://github.com/apache/kafka/blob/7071ded2a61448da21c149fa1d85b3999b0d2f73/gradle/rat.gradle#L101).
This led to inconsistent behavior if the `.git` directory was not present. With
this change, the `java-library` plugin (which has slightly more features than
the `java` plugin) is always applied.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #10394: MINOR: Always apply the java-library gradle plugin
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #10394:
URL: https://github.com/apache/kafka/pull/10394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org