You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/06/02 01:36:47 UTC
[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes
[ https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042510#comment-13042510 ]
Todd Lipcon commented on HBASE-3939:
------------------------------------
You currently have the server-side check all commented out.
I think you should do the following:
- refactor the code that grabs the VERSION constant into a static function somewhere
- call that new function from Invocation(Method,Object[])
- also call that new function from the block of code starting with "// Verify rpc version"
- remove all of the code referencing clientMethodsHash
- we need to bump the HBaseServer.CURRENT_VERSION constant as well.
> Some crossports of Hadoop IPC fixes
> -----------------------------------
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of date IPC version
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira