You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Wendy Smoak <ja...@wendysmoak.com> on 2005/09/03 06:13:43 UTC
Test failures in struts-tiles (was: svn commit: r265661)
> Author: niallp
> Date: Wed Aug 31 23:03:26 2005
> New Revision: 265661
>
> URL: http://svn.apache.org/viewcvs?rev=265661&view=rev
> Log:
> Remove I18nFactorySet copied code - highlighted by Sam Ruby
Ted reported this earlier today. In /struts/current/tiles:
test:test:
[junit] Running org.apache.struts.tiles.TestI18nFactorySet
[junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.078 sec
[junit] [ERROR] TEST org.apache.struts.tiles.TestI18nFactorySet FAILED
[junit] Running org.apache.struts.tiles.TestTilesPlugin
[junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.89 sec
BUILD FAILED
Tests are still passing in Standalone Tiles, but it doesn't have
TestI18nFactorySet.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Test failures in struts-tiles (was: svn commit: r265661)
Posted by Niall Pemberton <ni...@blueyonder.co.uk>.
Great thanks for the info Wendy. I should have looked at the maven files -
but confess to still being a bit of a maven-phobe.
Niall
----- Original Message -----
From: "Wendy Smoak" <ja...@wendysmoak.com>
Sent: Sunday, September 04, 2005 4:45 AM
> From: "Niall Pemberton" <ni...@blueyonder.co.uk>
>
> > Appears that maven expects a class named TestXXXX to be a JUint test.
I've
> > renamed TestI18nFactorySet to CustomI18nFactorySet and it now works.
>
> Maven itself doesn't expect anything in particular. It's coming from
> build/project.xml:
>
> <unitTest>
> <includes>
> <include>**/Test*.java</include>
> </includes>
> ...
>
> Thanks for fixing it!
> --
> Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Test failures in struts-tiles (was: svn commit: r265661)
Posted by Wendy Smoak <ja...@wendysmoak.com>.
From: "Niall Pemberton" <ni...@blueyonder.co.uk>
> Appears that maven expects a class named TestXXXX to be a JUint test. I've
> renamed TestI18nFactorySet to CustomI18nFactorySet and it now works.
Maven itself doesn't expect anything in particular. It's coming from
build/project.xml:
<unitTest>
<includes>
<include>**/Test*.java</include>
</includes>
...
Thanks for fixing it!
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Test failures in struts-tiles (was: svn commit: r265661)
Posted by Niall Pemberton <ni...@blueyonder.co.uk>.
Apologies, I ran the tests in 1.2 (using ant), but not 1.3 (using maven).
Appears that maven expects a class named TestXXXX to be a JUint test. I've
renamed TestI18nFactorySet to CustomI18nFactorySet and it now works.
I didn't add the new tests to the sandbox/standalone tiles - it needs a
ServletRequest and ServletContext and the 'mock' implementations for those
are not available in standalone tiles. IMO these mock implementations would
make for a good Jakarta Commons component...
org.apache.commons.web.servlet.MockServletConfig
org.apache.commons.web.servlet.MockServletContext
org.apache.commons.web.servlet.http.MockHttpSession
org.apache.commons.web.servlet.http.MockHttpServletRequest
org.apache.commons.web.servlet.http.MockHttpServletResponse
org.apache.commons.web.servlet.jsp.MockPageContext
Also the portlet equivalents might also be useful...
org.apache.commons.web.portlet.MockPortletConfig
org.apache.commons.web.portlet.MockPortletContext
org.apache.commons.web.portlet.Mock[Portlet/Action/Render]Request
org.apache.commons.web.portlet.Mock[Portlet/Action/Render]Response
org.apache.commons.web.portlet.MockPortletSession
I also think the portlet/servlet Maps in Commons Chain would fit well here.
org.apache.commons.chain.web.servlet.ServletApplicationScopeMap
org.apache.commons.chain.web.servlet.ServletHeaderMap
org.apache.commons.chain.web.servlet.ServletHeaderValuesMap
org.apache.commons.chain.web.servlet.ServletInitParamMap
org.apache.commons.chain.web.servlet.ServletParamMap
org.apache.commons.chain.web.servlet.ServletParamValuesMap
org.apache.commons.chain.web.servlet.ServletRequestScopeMap
org.apache.commons.chain.web.servlet.ServletSessionScopeMap
org.apache.commons.chain.web.portlet.PortletApplicationScopeMap
org.apache.commons.chain.web.portlet.PortletInitParamMap
org.apache.commons.chain.web.portlet.PortletParamMap
org.apache.commons.chain.web.portlet.PortletParamValuesMap
org.apache.commons.chain.web.portlet.PortletRequestScopeMap
org.apache.commons.chain.web.portlet.PortletSessionScopeMap
The ImplicitObjects class in commons-el provides the same functionality but
in a different way, so maybe its something they could utilize.
Niall
----- Original Message -----
From: "Wendy Smoak" <ja...@wendysmoak.com>
Sent: Saturday, September 03, 2005 5:13 AM
> > Author: niallp
> > Date: Wed Aug 31 23:03:26 2005
> > New Revision: 265661
> >
> > URL: http://svn.apache.org/viewcvs?rev=265661&view=rev
> > Log:
> > Remove I18nFactorySet copied code - highlighted by Sam Ruby
>
> Ted reported this earlier today. In /struts/current/tiles:
>
> test:test:
> [junit] Running org.apache.struts.tiles.TestI18nFactorySet
> [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.078 sec
> [junit] [ERROR] TEST org.apache.struts.tiles.TestI18nFactorySet FAILED
> [junit] Running org.apache.struts.tiles.TestTilesPlugin
> [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.89 sec
>
> BUILD FAILED
>
> Tests are still passing in Standalone Tiles, but it doesn't have
> TestI18nFactorySet.
>
> --
> Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org