You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Mridul Pathak (JIRA)" <ji...@apache.org> on 2008/03/28 06:36:24 UTC
[jira] Created: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
CRUD services/UI for AgreementWorkEffortAppl Entity
---------------------------------------------------
Key: OFBIZ-1722
URL: https://issues.apache.org/jira/browse/OFBIZ-1722
Project: OFBiz
Issue Type: New Feature
Components: accounting, workeffort
Affects Versions: SVN trunk
Reporter: Mridul Pathak
Priority: Minor
Fix For: SVN trunk
1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Nitin Bhawsar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitin Bhawsar updated OFBIZ-1722:
---------------------------------
Attachment: AgrrementWorkEffortAppl.Patch
Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
Create Lookups for Agreement and AgreementItems.
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Nitin Bhawsar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitin Bhawsar updated OFBIZ-1722:
---------------------------------
Attachment: AgrrementWorkEffortAppl.Patch
Here is the modified patch for the same.
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgrrementWorkEffortAppl.Patch, AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Mridul Pathak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584023#action_12584023 ]
Mridul Pathak commented on OFBIZ-1722:
--------------------------------------
Nitin,
I looked at your patch but not tested it yet. Your patch looks fine. There are some areas of improvements that I would like to suggest.
1) Some of the uiLabels are not defined in a standard way.
2) There are duplicate uiLabels. I think we can define most of the uiLabels in Accounting component and just use them in Workeffort. Only the essential ones must be defined in the WorkEffort.
3) In Menus.xml naming conventions of the newly added menus are not according to the standard conventions.
Can you please find and fix these issues and attach an updated patch after a good review and testing.
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Mridul Pathak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583057#action_12583057 ]
Mridul Pathak commented on OFBIZ-1722:
--------------------------------------
Jacopo,
Will it be alright, if these CRUD services/UI are kept in Accounting Component for now? Later we can work on to move all the Agreement related stuff to the Party Component. I'll continue with that after this issue is resolved.
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Nitin Bhawsar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitin Bhawsar updated OFBIZ-1722:
---------------------------------
Comment: was deleted
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Ravindra Mandre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravindra Mandre updated OFBIZ-1722:
-----------------------------------
Attachment: AgreementWorkEffortAppls.patch
The patch is uploaded with some minor changes which are as :
1) Moved the property "WorkEffortWorkEffortAgreementAlreadyExist" from WorkEffortUiLabels.xml to AccountingUiLabels.xml and renamed it as required and done the needful changes. And made the chages for "ListAgreementWorkEffortAppls".
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgreementWorkEffortAppls.patch, AgreementWorkEffortAppls.patch, AgrrementWorkEffortAppl.Patch, AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Mridul Pathak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602639#action_12602639 ]
Mridul Pathak commented on OFBIZ-1722:
--------------------------------------
I have reviewed the attached patch. Looks good to me. There are two improvements:
1) Move property "WorkEffortWorkEffortAgreementAlreadyExist" from WorkEffortUiLabels.xml to AccountingUiLabels.xml and rename (should be AccountingAgreementWorkEffortApplAlreadyExists) it properly. Also the corresponding changes to the createAgreementWorkEffortAppl will be needed to be done.
2) Value of the property "ListAgreementWorkEffortAppls" in AccountingUiLabels.xml must be plural.
Rest of the patch looks good.
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgreementWorkEffortAppls.patch, AgrrementWorkEffortAppl.Patch, AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Nitin Bhawsar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitin Bhawsar updated OFBIZ-1722:
---------------------------------
Attachment: AgrrementWorkEffortAppl.Patch
Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
Create Lookups for Agreement and AgreementItems.
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Ravindra Mandre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravindra Mandre updated OFBIZ-1722:
-----------------------------------
Attachment: AgreementWorkEffortAppls.patch
This patch is uploaded with few modifications.
1) UiLabels are done in proper order.
2) Requests are placed are proper place in controller .
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgreementWorkEffortAppls.patch, AgrrementWorkEffortAppl.Patch, AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-1722.
--------------------------------------
Resolution: Fixed
Ravinda and Nitin thanks for your work.
Your patch is in rev # 663966.
Thanks Mridul Pathak for your useful comments.
--
Ashish Vijaywargiya
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgreementWorkEffortAppls.patch, AgreementWorkEffortAppls.patch, AgrrementWorkEffortAppl.Patch, AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-1722:
------------------------------------------
Assignee: Ashish Vijaywargiya
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgreementWorkEffortAppls.patch, AgrrementWorkEffortAppl.Patch, AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583030#action_12583030 ]
Jacopo Cappellato commented on OFBIZ-1722:
------------------------------------------
Hi,
this is probably off topic here, but sooner or later we will have to move all the agreement screens from the accounting to the party component/application.
Jacopo
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AgrrementWorkEffortAppl.Patch
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1722) CRUD services/UI for
AgreementWorkEffortAppl Entity
Posted by "Nitin Bhawsar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitin Bhawsar updated OFBIZ-1722:
---------------------------------
Attachment: (was: AgrrementWorkEffortAppl.Patch)
> CRUD services/UI for AgreementWorkEffortAppl Entity
> ---------------------------------------------------
>
> Key: OFBIZ-1722
> URL: https://issues.apache.org/jira/browse/OFBIZ-1722
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, workeffort
> Affects Versions: SVN trunk
> Reporter: Mridul Pathak
> Priority: Minor
> Fix For: SVN trunk
>
>
> 1) Create CRUD services for AgreementWorkEffortAppl. This should go in Accounting Component.
> 2) Create CRUD UI for AgreementWorkEffortAppl in Accounting --> Agreement to Add/Edit/Delete an AgreementWorkEffortAppl for an agreementId.
> 3) Create another CRUD UI in WorkEffort --> WorkEffort to Add/Edit/Delete an AgreementWorkEffortAppl for a workEffortId.
> 4) Create Lookups for Agreement and AgreementItems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.