You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/05 05:41:41 UTC

[GitHub] [dubbo-go] stulzq opened a new pull request #1302: Ftr: add logrus support

stulzq opened a new pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302


   **What this PR does**:
   
   Add logrus support.
   
   **Which issue(s) this PR fixes**:
   
   it's same to this issue #1210 
   
   **Special notes for your reviewer**:
   
   Logrus does not directly support configuration file, so I didn't implement reading configuration from file, but I have exposed several functions that can be provided to users to set logrus.
   
   ![image](https://user-images.githubusercontent.com/13200155/124420097-6934da80-dd91-11eb-8776-d392f8699aa8.png)
   
   
   
   **Does this PR introduce a user-facing change?**:
   
   No changes are required for the current user, an optional configuration item is provided.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] stulzq closed pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
stulzq closed pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] stulzq commented on pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
stulzq commented on pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302#issuecomment-874044412


   > 建议可以使用dubbogo的extension机制，做logger support的扩展
   
   了解，我把这个 pr 关闭了，使用 extension 机制重新实现一个


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] stulzq commented on pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
stulzq commented on pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302#issuecomment-874420290


   > 建议可以使用dubbogo的extension机制，做logger support的扩展
   
   extension 包（dubbo.apache.org/dubbo-go/v3/common/extension）里的文件 import 了 logger 包（dubbo.apache.org/dubbo-go/v3/common/logger），如果 logger 使用 extension 机制，我理解的是需要在 logger 的 init 函数里设置 extension.SetLogger() 这样的调用，那么在 logger 将会需要引用 extension 包，这样就会造成循环依赖 。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] stulzq commented on pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
stulzq commented on pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302#issuecomment-874038521






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
hxmhlt commented on pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302#issuecomment-874037963


   建议可以使用dubbogo的extension机制，做logger support的扩展


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
hxmhlt commented on pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302#issuecomment-874037963


   建议可以使用dubbogo的extension机制，做logger support的扩展


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] stulzq closed pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
stulzq closed pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] stulzq closed pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
stulzq closed pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] xavier-niu commented on pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
xavier-niu commented on pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302#issuecomment-874479428


   > > 建议可以使用dubbogo的extension机制，做logger support的扩展
   > 
   > extension 包（dubbo.apache.org/dubbo-go/v3/common/extension）里的文件 import 了 logger 包（dubbo.apache.org/dubbo-go/v3/common/logger），如果 logger 使用 extension 机制，我理解的是需要在 logger 的 init 函数里设置 extension.SetLogger() 这样的调用，那么在 logger 将会需要引用 extension 包，这样就会造成循环依赖 。
   
   Yes, you should carefully handle with extension package.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] xavier-niu commented on pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
xavier-niu commented on pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302#issuecomment-874479428


   > > 建议可以使用dubbogo的extension机制，做logger support的扩展
   > 
   > extension 包（dubbo.apache.org/dubbo-go/v3/common/extension）里的文件 import 了 logger 包（dubbo.apache.org/dubbo-go/v3/common/logger），如果 logger 使用 extension 机制，我理解的是需要在 logger 的 init 函数里设置 extension.SetLogger() 这样的调用，那么在 logger 将会需要引用 extension 包，这样就会造成循环依赖 。
   
   Yes, you should carefully handle with extension package.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] stulzq commented on pull request #1302: Ftr: add logrus support

Posted by GitBox <gi...@apache.org>.
stulzq commented on pull request #1302:
URL: https://github.com/apache/dubbo-go/pull/1302#issuecomment-874038521


   close and reopen, trigger the CI check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org