[GitHub] [arrow] zeroshade commented on a diff in pull request #34342: GH-33466: [Go][Parquet] Add support for Dictionary arrays to pqarrow

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #34342:
URL: https://github.com/apache/arrow/pull/34342#discussion_r1119012302


##########
go/arrow/array/dictionary.go:
##########
@@ -883,6 +885,60 @@ func (b *dictionaryBuilder) AppendArray(arr arrow.Array) error {
 	return nil
 }
 
+func (b *dictionaryBuilder) AppendIndices(indices []int, valid []bool) {

Review Comment:
   Currently i didn't add explicit tests for them, just the indirect testing via the new tests for reading/writing dictionary arrays directly. That's a good point, I should add more explicit tests for these methods here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org