You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/01 00:38:38 UTC

[GitHub] [spark] maropu commented on pull request #29270: [SPARK-32466][TEST][SQL] Add PlanStabilitySuite to detect SparkPlan regression

maropu commented on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-667439259


   > One of my worries is that: this test generates plans with empty tables, and we lost test coverage for things like SMJ. Can the variant feature help to improve the test coverage here?
   
   Interesting point! How about injecting stats data when creating TPCDS tables? https://github.com/apache/spark/compare/master...maropu:SPARK-32466 This might make it possible to make generated plans closer to the actual ones.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org