You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2023/10/12 07:31:09 UTC
[kudu-CR] Remove unused parameter
Wang Xixu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20565
Change subject: Remove unused parameter
......................................................................
Remove unused parameter
Parameter is_leader is not used in the implement of
function Status Tablet::DecodeWriteOperations, therefore
remove it.
Change-Id: I7a89708d24c7a1e9fb45a9fe451cc8b217556ffd
---
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
3 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/20565/1
--
To view, visit http://gerrit.cloudera.org:8080/20565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a89708d24c7a1e9fb45a9fe451cc8b217556ffd
Gerrit-Change-Number: 20565
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
[kudu-CR] Remove unused parameter
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: Remove unused parameter
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7a89708d24c7a1e9fb45a9fe451cc8b217556ffd
Gerrit-Change-Number: 20565
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Remove unused parameter
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20565 )
Change subject: Remove unused parameter
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a89708d24c7a1e9fb45a9fe451cc8b217556ffd
Gerrit-Change-Number: 20565
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Oct 2023 14:31:47 +0000
Gerrit-HasComments: No
[kudu-CR] Remove unused parameter
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20565 )
Change subject: Remove unused parameter
......................................................................
Patch Set 1: Verified+1
unrelated test failures (TSAN)
--
To view, visit http://gerrit.cloudera.org:8080/20565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a89708d24c7a1e9fb45a9fe451cc8b217556ffd
Gerrit-Change-Number: 20565
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Oct 2023 14:32:11 +0000
Gerrit-HasComments: No
[kudu-CR] Remove unused parameter
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20565 )
Change subject: Remove unused parameter
......................................................................
Remove unused parameter
Parameter is_leader is not used in the implement of
function Status Tablet::DecodeWriteOperations, therefore
remove it.
Change-Id: I7a89708d24c7a1e9fb45a9fe451cc8b217556ffd
Reviewed-on: http://gerrit.cloudera.org:8080/20565
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
3 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a89708d24c7a1e9fb45a9fe451cc8b217556ffd
Gerrit-Change-Number: 20565
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)