[eclipse 2.5] workspace parameter side-effect

[nicolas de loof <ni...@apache.org>]

Hello,

setting the workspace parameter to my workspace has a strange side-effect :

my eclipse .project files are not created in my project folder, but in my
eclipse workspace directory. I like the idea to automagically detect
available projects in my eclipse (MECLIPSE-344) but I prefer to have the
"classic" .project files created in my svn checkout directory.

Setting <eclipse.projectDir>${basedir}</eclipse.projectDir> fixes this, but
reading the plugin source code I don't understand how the workspace
parameter changed the output dir.

I also noticed the new workspace parameter, that is 100% eclipse related, is
in AbstractIdeSupportMojo class and not in EclipsePlugin ;-p

Nico

Re: [eclipse 2.5] workspace parameter side-effect

[Arnaud HERITIER <ah...@gmail.com>]

Sorry, I didn't see this thread.

The issue is : http://jira.codehaus.org/browse/MECLIPSE-374

I renamed the ${eclipse.workspace} to ${eclipse.projectDir} because the
parameter is really the directory where is write the configuration files for
eclipse.
There's no default value for this property and it is manually computed in
the validate() method of the plugin. I don't see where the side effect can
be. I just renamed the expression and not the java property. And I don't see
something in Richard's code which changes the value of this property.

Nicolas : I didn't notice the workspace in the abstractIDE. I'll move it.

Arnaud

On Tue, Feb 5, 2008 at 2:04 PM, Richard van Nieuwenhoven <ni...@cfc.at> wrote:

> Hi,
>
> The original use of this parameter was for this "strange" effect. When i
> introduced the new parameter i called it workspaceToConnect because the
> parameter workspace was in use.
>
> Arnaud fixed a jira (don't remember the number) that this effect has
> nothing to do with the workspace and renamed it, so the parameter name
> was now free and replaced the new workspaceToConnect property..
>
> So someware on this way, the renaming went wrong...
>
> Arnaud should be able to tell us where.
>
> Ritchie
>
>
>
>
>
> nicolas de loof wrote:
> > Hello,
> >
> > setting the workspace parameter to my workspace has a strange
> side-effect :
> >
> > my eclipse .project files are not created in my project folder, but in
> my
> > eclipse workspace directory. I like the idea to automagically detect
> > available projects in my eclipse (MECLIPSE-344) but I prefer to have the
> > "classic" .project files created in my svn checkout directory.
> >
> > Setting <eclipse.projectDir>${basedir}</eclipse.projectDir> fixes this,
> but
> > reading the plugin source code I don't understand how the workspace
> > parameter changed the output dir.
> >
> > I also noticed the new workspace parameter, that is 100% eclipse
> related, is
> > in AbstractIdeSupportMojo class and not in EclipsePlugin ;-p
> >
> > Nico
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

Re: [eclipse 2.5] workspace parameter side-effect

[Richard van Nieuwenhoven <ni...@cfc.at>]

Hi,

The original use of this parameter was for this "strange" effect. When i
introduced the new parameter i called it workspaceToConnect because the
parameter workspace was in use.

Arnaud fixed a jira (don't remember the number) that this effect has
nothing to do with the workspace and renamed it, so the parameter name
was now free and replaced the new workspaceToConnect property..

So someware on this way, the renaming went wrong...

Arnaud should be able to tell us where.

Ritchie





nicolas de loof wrote:
> Hello,
> 
> setting the workspace parameter to my workspace has a strange side-effect :
> 
> my eclipse .project files are not created in my project folder, but in my
> eclipse workspace directory. I like the idea to automagically detect
> available projects in my eclipse (MECLIPSE-344) but I prefer to have the
> "classic" .project files created in my svn checkout directory.
> 
> Setting <eclipse.projectDir>${basedir}</eclipse.projectDir> fixes this, but
> reading the plugin source code I don't understand how the workspace
> parameter changed the output dir.
> 
> I also noticed the new workspace parameter, that is 100% eclipse related, is
> in AbstractIdeSupportMojo class and not in EclipsePlugin ;-p
> 
> Nico
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org