You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by ec...@apache.org on 2011/10/28 22:07:47 UTC
svn commit: r1190531 -
/incubator/accumulo/trunk/src/core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java
Author: ecn
Date: Fri Oct 28 20:07:47 2011
New Revision: 1190531
URL: http://svn.apache.org/viewvc?rev=1190531&view=rev
Log:
ACCUMULO-93 ZooLock moved to accumulo.server in 1.4
Modified:
incubator/accumulo/trunk/src/core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java
Modified: incubator/accumulo/trunk/src/core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java
URL: http://svn.apache.org/viewvc/incubator/accumulo/trunk/src/core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java?rev=1190531&r1=1190530&r2=1190531&view=diff
==============================================================================
--- incubator/accumulo/trunk/src/core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java (original)
+++ incubator/accumulo/trunk/src/core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java Fri Oct 28 20:07:47 2011
@@ -17,6 +17,7 @@
package org.apache.accumulo.core.client.admin;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
import java.util.Map;
@@ -38,19 +39,12 @@ import org.apache.accumulo.core.tabletse
import org.apache.accumulo.core.util.ArgumentChecker;
import org.apache.accumulo.core.util.ThriftUtil;
import org.apache.accumulo.core.zookeeper.ZooCache;
-import org.apache.accumulo.core.zookeeper.ZooLock;
import org.apache.accumulo.core.zookeeper.ZooUtil;
-import org.apache.log4j.Logger;
-import org.apache.thrift.TApplicationException;
-import org.apache.thrift.TException;
-import org.apache.thrift.TServiceClient;
-import org.apache.thrift.transport.TTransportException;
/**
* Provides a class for administering the accumulo instance
*/
public class InstanceOperations {
- private static final Logger log = Logger.getLogger(InstanceOperations.class);
private Instance instance;
private AuthInfo credentials;
@@ -139,13 +133,14 @@ public class InstanceOperations {
String path = ZooUtil.getRoot(instance) + Constants.ZTSERVERS;
List<String> results = new ArrayList<String>();
for (String candidate : cache.getChildren(path)) {
- try {
- byte[] data = ZooLock.getLockData(cache, path + "/" + candidate);
+ List<String> children = cache.getChildren(path + "/" + candidate);
+ if (children != null && children.size() > 0) {
+ List<String> copy = new ArrayList<String>(children);
+ Collections.sort(copy);
+ byte[] data = cache.get(path + "/" + candidate + "/" + copy.get(0));
if (data != null && !"master".equals(new String(data))) {
results.add(candidate);
}
- } catch (Exception ex) {
- log.error("Unable to read lock data:" + path);
}
}
return results;