You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/30 17:49:30 UTC
[GitHub] [spark] shrutig opened a new pull request #29914: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
shrutig opened a new pull request #29914:
URL: https://github.com/apache/spark/pull/29914
### What changes were proposed in this pull request?
This is a backport PR for branch-3.0. This change was raised to `master` branch in `https://github.com/apache/spark/pull/29872`
When `peakMemoryMetrics` in `ExecutorSummary` is `Option.empty`, then the `ExecutorMetricsJsonSerializer#serialize` method does not execute the `jsonGenerator.writeObject` method. This causes the json to be generated with `peakMemoryMetrics` key added to the serialized string, but no corresponding value.
This causes an error to be thrown when it is the next key `attributes` turn to be added to the json:
`com.fasterxml.jackson.core.JsonGenerationException: Can not write a field name, expecting a value
`
### Why are the changes needed?
At the start of the Spark job, if `peakMemoryMetrics` is `Option.empty`, then it causes
a `com.fasterxml.jackson.core.JsonGenerationException` to be thrown when we navigate to the Executors tab in Spark UI.
Complete stacktrace:
> com.fasterxml.jackson.core.JsonGenerationException: Can not write a field name, expecting a value
> at com.fasterxml.jackson.core.JsonGenerator._reportError(JsonGenerator.java:2080)
> at com.fasterxml.jackson.core.json.WriterBasedJsonGenerator.writeFieldName(WriterBasedJsonGenerator.java:161)
> at com.fasterxml.jackson.databind.ser.BeanPropertyWriter.serializeAsField(BeanPropertyWriter.java:725)
> at com.fasterxml.jackson.databind.ser.std.BeanSerializerBase.serializeFields(BeanSerializerBase.java:721)
> at com.fasterxml.jackson.databind.ser.BeanSerializer.serialize(BeanSerializer.java:166)
> at com.fasterxml.jackson.databind.ser.std.CollectionSerializer.serializeContents(CollectionSerializer.java:145)
> at com.fasterxml.jackson.module.scala.ser.IterableSerializer.serializeContents(IterableSerializerModule.scala:26)
> at com.fasterxml.jackson.module.scala.ser.IterableSerializer.serializeContents$(IterableSerializerModule.scala:25)
> at com.fasterxml.jackson.module.scala.ser.UnresolvedIterableSerializer.serializeContents(IterableSerializerModule.scala:54)
> at com.fasterxml.jackson.module.scala.ser.UnresolvedIterableSerializer.serializeContents(IterableSerializerModule.scala:54)
> at com.fasterxml.jackson.databind.ser.std.AsArraySerializerBase.serialize(AsArraySerializerBase.java:250)
> at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider._serialize(DefaultSerializerProvider.java:480)
> at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider.serializeValue(DefaultSerializerProvider.java:319)
> at com.fasterxml.jackson.databind.ObjectMapper._configAndWriteValue(ObjectMapper.java:4094)
> at com.fasterxml.jackson.databind.ObjectMapper.writeValueAsString(ObjectMapper.java:3404)
> at org.apache.spark.ui.exec.ExecutorsPage.allExecutorsDataScript$1(ExecutorsTab.scala:64)
> at org.apache.spark.ui.exec.ExecutorsPage.render(ExecutorsTab.scala:76)
> at org.apache.spark.ui.WebUI.$anonfun$attachPage$1(WebUI.scala:89)
> at org.apache.spark.ui.JettyUtils$$anon$1.doGet(JettyUtils.scala:80)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at org.sparkproject.jetty.servlet.ServletHolder.handle(ServletHolder.java:873)
> at org.sparkproject.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1623)
> at org.apache.spark.ui.HttpSecurityFilter.doFilter(HttpSecurityFilter.scala:95)
> at org.sparkproject.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1610)
> at org.sparkproject.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:540)
> at org.sparkproject.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255)
> at org.sparkproject.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1345)
> at org.sparkproject.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:203)
> at org.sparkproject.jetty.servlet.ServletHandler.doScope(ServletHandler.java:480)
> at org.sparkproject.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:201)
> at org.sparkproject.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1247)
> at org.sparkproject.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:144)
> at org.sparkproject.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:753)
> at org.sparkproject.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:220)
> at org.sparkproject.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
> at org.sparkproject.jetty.server.Server.handle(Server.java:505)
> at org.sparkproject.jetty.server.HttpChannel.handle(HttpChannel.java:370)
> at org.sparkproject.jetty.server.HttpConnection.onFillable(HttpConnection.java:267)
> at org.sparkproject.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:305)
> at org.sparkproject.jetty.io.FillInterest.fillable(FillInterest.java:103)
> at org.sparkproject.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117)
> at org.sparkproject.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:333)
> at org.sparkproject.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:310)
> at org.sparkproject.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:168)
> at org.sparkproject.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:126)
> at org.sparkproject.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:366)
> at org.sparkproject.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:698)
> at org.sparkproject.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:804)
> at java.base/java.lang.Thread.run(Thread.java:834)
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702435142
**[Test build #129322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129322/testReport)** for PR 29914 at commit [`6f4f852`](https://github.com/apache/spark/commit/6f4f8527e6db096490f36f73256520d954c18f48).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701885228
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shrutig commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
shrutig commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701882196
> I just noticed that you put ExecutorSummarySuite in core/src/test/java ? Can you move to core/src/test/scala?
Thanks for pointing it out. I have made the above change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702435142
**[Test build #129322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129322/testReport)** for PR 29914 at commit [`6f4f852`](https://github.com/apache/spark/commit/6f4f8527e6db096490f36f73256520d954c18f48).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702493310
Thanks! Merging to branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702480725
**[Test build #129322 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129322/testReport)** for PR 29914 at commit [`6f4f852`](https://github.com/apache/spark/commit/6f4f8527e6db096490f36f73256520d954c18f48).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701546917
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701629895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702427867
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701885209
**[Test build #129301 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129301/testReport)** for PR 29914 at commit [`f7653f8`](https://github.com/apache/spark/commit/f7653f8c25443b1e5de4ccbf74c9714a521081b8).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702448589
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33935/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702353576
**[Test build #129317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129317/testReport)** for PR 29914 at commit [`6f4f852`](https://github.com/apache/spark/commit/6f4f8527e6db096490f36f73256520d954c18f48).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702453657
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701883255
**[Test build #129301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129301/testReport)** for PR 29914 at commit [`f7653f8`](https://github.com/apache/spark/commit/f7653f8c25443b1e5de4ccbf74c9714a521081b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701629895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701883255
**[Test build #129301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129301/testReport)** for PR 29914 at commit [`f7653f8`](https://github.com/apache/spark/commit/f7653f8c25443b1e5de4ccbf74c9714a521081b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shrutig commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
shrutig commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702357439
> Can you also open a follow-up PR to move the test to core/src/test/scala in master branch too?
https://github.com/apache/spark/pull/29926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702453664
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33935/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702453525
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33935/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701629361
The change looks good. Pending moving the test to correct path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701885236
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129301/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702353576
**[Test build #129317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129317/testReport)** for PR 29914 at commit [`6f4f852`](https://github.com/apache/spark/commit/6f4f8527e6db096490f36f73256520d954c18f48).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #29914:
URL: https://github.com/apache/spark/pull/29914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702432653
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702481449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701882734
@shrutig Thanks for doing that. Can you also open a follow-up PR to move the test to core/src/test/scala in master branch too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702481449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702427867
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702453657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701546426
**[Test build #129283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129283/testReport)** for PR 29914 at commit [`9999bcb`](https://github.com/apache/spark/commit/9999bcbc79ec658e274e10b6f139aa936b2bc2f5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701628725
**[Test build #129283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129283/testReport)** for PR 29914 at commit [`9999bcb`](https://github.com/apache/spark/commit/9999bcbc79ec658e274e10b6f139aa936b2bc2f5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702427875
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129317/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701885228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701546426
**[Test build #129283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129283/testReport)** for PR 29914 at commit [`9999bcb`](https://github.com/apache/spark/commit/9999bcbc79ec658e274e10b6f139aa936b2bc2f5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29914: [SPARK-32996][Web-UI][3.0] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-702427412
**[Test build #129317 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129317/testReport)** for PR 29914 at commit [`6f4f852`](https://github.com/apache/spark/commit/6f4f8527e6db096490f36f73256520d954c18f48).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29914: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29914:
URL: https://github.com/apache/spark/pull/29914#issuecomment-701546917
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org