You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by Ngone51 <gi...@git.apache.org> on 2018/05/02 02:01:46 UTC

[GitHub] spark pull request #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSched...

GitHub user Ngone51 opened a pull request:

    https://github.com/apache/spark/pull/21209

    [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBackend.killExecutors

    ## What changes were proposed in this pull request?
    
    In method *CoarseGrainedSchedulerBackend.killExecutors()*, `numPendingExecutors` should add 
    `executorsToKill.size` rather than `knownExecutors.size` if we do not adjust target number of executors.
    
    ## How was this patch tested?
    
    N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ngone51/spark SPARK-24141

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21209
    
----
commit 264f316c178ff32ea632cc3db7e20ab68d555b85
Author: wuyi <ng...@...>
Date:   2018-05-02T01:50:01Z

    fix a bug in killExecutors

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by vanzin <gi...@git.apache.org>.

Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    LGTM. I have a feeling the current code would heal itself later (by the fact that `ExecutorAllocationManager` calls `requestTotalExecutors`) but this looks more correct.
    
    Merging to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    **[Test build #90343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90343/testReport)** for PR 21209 at commit [`264f316`](https://github.com/apache/spark/commit/264f316c178ff32ea632cc3db7e20ab68d555b85).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    **[Test build #90343 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90343/testReport)** for PR 21209 at commit [`264f316`](https://github.com/apache/spark/commit/264f316c178ff32ea632cc3db7e20ab68d555b85).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by Ngone51 <gi...@git.apache.org>.

Github user Ngone51 commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90343/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by Ngone51 <gi...@git.apache.org>.

Github user Ngone51 commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    ping @jiangxb1987 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21209: [SPARK-24141][CORE] Fix bug in CoarseGrainedSchedulerBac...

Posted by Ngone51 <gi...@git.apache.org>.

Github user Ngone51 commented on the issue:

    https://github.com/apache/spark/pull/21209
  
    ping @squito @vanzin 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org