[jira] [Commented] (HIVE-4355) HCatalog test TestPigHCatUtil might fail on JDK7

["Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738356#comment-13738356 ] 

Jarek Jarcec Cecho commented on HIVE-4355:
------------------------------------------

Hi [~ashutoshc],
thank you very much for taking a look on this patch! Please accept my apologies for late response, I've unfortunately completely missed the updates.

The issue here is that method {{testGetBagSubSchemaConfigured}} is setting System properties in order to test the behavior, but it's not cleaning them after the test. This do not appear to be an issue on pure JDK6 as the method {{testGetBagSubSchema}} is being executed before {{testGetBagSubSchemaConfigured}}. However when I compiled the tests with JDK6 and then executed them on JDK7, the order in which the two testing methods are executed has changed - the method {{testGetBagSubSchemaConfigured}} was executed before {{testGetBagSubSchema}}. As the {{testGetBagSubSchemaConfigured}} was not cleaning up the System properties, the second method {{testGetBagSubSchema}} has picked them up and the test itself has failed. Hope that it helps!
                
> HCatalog test TestPigHCatUtil might fail on JDK7
> ------------------------------------------------
>
>                 Key: HIVE-4355
>                 URL: https://issues.apache.org/jira/browse/HIVE-4355
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HCatalog
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>         Attachments: HIVE-4355.patch
>
>
> I’ve tried interesting scenario. I’ve compiled hcatalog with JDK 6 (including tests) and run the tests itself on JDK 7. My motivation was to see what will happen to users that will download official Apache release (usually compiled on JDK 6) and will run it on JDK 7. I’ve seen {{TestPigHCatUtil}} failing because the order of method calls was different then when compiling and running the tests only on JDK 6 or only on JDK 7.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira