[GitHub] [nifi] aeaversa edited a comment on issue #3440: NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue

[GitBox <gi...@apache.org>]

aeaversa edited a comment on issue #3440: NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue
URL: https://github.com/apache/nifi/pull/3440#issuecomment-485498533
 
 
   > @patricker @aeaversa That conditional with `dataContext.size > 0` looks like its disabling the download and view button when the underlying content is zero bytes. This is not the same as the content being unavailable. I do not believe we disable view and download buttons when the content is zero bytes elsewhere.
   
   @mcgilman - The logic under the "showDetails()" method within "nf-queue-listing.js" simply hides the Download/View buttons when the file has no content to view or download (i.e. - 0 bytes). Previously I had a simple dialog popup indicating that the flowfile was empty and could not perform the function but after @patricker recommended that a simple disabled is sufficient, that dialog was removed. Is there a preference as to how you think it should be presented? My thanks again for all the great feedback.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services