You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Szehon Ho <sz...@cloudera.com> on 2014/04/07 22:17:22 UTC
Review Request 20103: HIVE-6843 INSTR for UTF-8 returns incorrect position
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20103/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
Seems the original authors wanted to avoid encoding, but this is not possible if you want to handle Unicode characters.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java 7f4a807
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFUtils.java d9338a5
Diff: https://reviews.apache.org/r/20103/diff/
Testing
-------
Adding some unicode test of Cyrillic chars.
Thanks,
Szehon Ho
Re: Review Request 20103: HIVE-6843 INSTR for UTF-8 returns incorrect
position
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20103/#review40839
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Dere
On April 19, 2014, 12:06 a.m., Szehon Ho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20103/
> -----------------------------------------------------------
>
> (Updated April 19, 2014, 12:06 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Seems the original authors wanted to avoid encoding, but this is not possible if you want to handle Unicode characters.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java 7f4a807
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFUtils.java d9338a5
>
> Diff: https://reviews.apache.org/r/20103/diff/
>
>
> Testing
> -------
>
> Adding some unicode test of Cyrillic chars.
>
>
> Thanks,
>
> Szehon Ho
>
>
Re: Review Request 20103: HIVE-6843 INSTR for UTF-8 returns incorrect
position
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20103/
-----------------------------------------------------------
(Updated April 19, 2014, 12:06 a.m.)
Review request for hive.
Changes
-------
Handle the 'surrogate' case.
Repository: hive-git
Description
-------
Seems the original authors wanted to avoid encoding, but this is not possible if you want to handle Unicode characters.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java 7f4a807
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFUtils.java d9338a5
Diff: https://reviews.apache.org/r/20103/diff/
Testing
-------
Adding some unicode test of Cyrillic chars.
Thanks,
Szehon Ho