You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/18 23:41:07 UTC

[GitHub] [incubator-tvm] comaniac opened a new pull request #6939: Lazy import XGBoost

comaniac opened a new pull request #6939:
URL: https://github.com/apache/incubator-tvm/pull/6939


   I encountered the same issue as this one: https://discuss.tvm.apache.org/t/conflict-with-xgboost-when-thrust-is-enabled/6889 with CUDA 10.0 and thrust enabled after upgrading XGBoost to 1.1.0. Since XGBoost is imported by AutoTVM, and AutoTVM is used everywhere (e.g., TOPI, VM, etc), I got the error even with only `from tvm import relay`, as mentioned in the latest reply in the post.
   
   Since we cannot reproduce this error in docker and it's a potential issue, this PR makes the XGBoost import lazy.
   
   cc @merrymercy @tqchen @vinx13 @zhiics 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] merrymercy commented on pull request #6939: Lazy import XGBoost

Posted by GitBox <gi...@apache.org>.
merrymercy commented on pull request #6939:
URL: https://github.com/apache/incubator-tvm/pull/6939#issuecomment-732788532


   @comaniac  Missing the package is a fatal error. We should raise an exception when we fail to import it instead of prinitng a message. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen merged pull request #6939: Lazy import XGBoost

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6939:
URL: https://github.com/apache/incubator-tvm/pull/6939


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org