You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/03 14:17:08 UTC

[GitHub] [arrow] carols10cents commented on a change in pull request #8820: ARROW-10791: [Rust] StreamReader, read_dictionary duplicating schema info

carols10cents commented on a change in pull request #8820:
URL: https://github.com/apache/arrow/pull/8820#discussion_r535262084



##########
File path: rust/integration-testing/src/bin/arrow-json-integration-test.rs
##########
@@ -489,7 +489,12 @@ fn array_from_json(
             Ok(Arc::new(array))
         }
         DataType::Dictionary(key_type, value_type) => {
-            let dict_id = field.dict_id();
+            let dict_id = field.dict_id().ok_or_else(|| {

Review comment:
       No worries! I remember I sent you a rebased PR to your branch that was... complicated... so I'm not surprised :) Thanks for the merge!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org