You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "xuziyang (via GitHub)" <gi...@apache.org> on 2023/03/31 06:45:39 UTC
[GitHub] [rocketmq] xuziyang opened a new pull request, #6517: [ISSUE #6516] Remove redundant code from ThreadLocalIndex
xuziyang opened a new pull request, #6517:
URL: https://github.com/apache/rocketmq/pull/6517
fix https://github.com/apache/rocketmq/issues/6516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Oliverwqcwrw merged pull request #6517: [ISSUE #6516] Remove redundant code from ThreadLocalIndex
Posted by "Oliverwqcwrw (via GitHub)" <gi...@apache.org>.
Oliverwqcwrw merged PR #6517:
URL: https://github.com/apache/rocketmq/pull/6517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Oliverwqcwrw commented on pull request #6517: [ISSUE #6516] Remove redundant code from ThreadLocalIndex
Posted by "Oliverwqcwrw (via GitHub)" <gi...@apache.org>.
Oliverwqcwrw commented on PR #6517:
URL: https://github.com/apache/rocketmq/pull/6517#issuecomment-1526892786
@xuziyang ,The pr can be merged after the required checks have been passed,
Please rebase develop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xuziyang commented on pull request #6517: [ISSUE #6516] Remove redundant code from ThreadLocalIndex
Posted by "xuziyang (via GitHub)" <gi...@apache.org>.
xuziyang commented on PR #6517:
URL: https://github.com/apache/rocketmq/pull/6517#issuecomment-1515622773
Why did the unit test fail? It has nothing to do with my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6517: [ISSUE #6516] Remove redundant code from ThreadLocalIndex
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6517:
URL: https://github.com/apache/rocketmq/pull/6517#issuecomment-1498368979
## [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6517?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6517](https://codecov.io/gh/apache/rocketmq/pull/6517?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5546114) into [develop](https://codecov.io/gh/apache/rocketmq/commit/24bc8c90923b762be5d1d74da6bc1b27447ebce4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24bc8c9) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## develop #6517 +/- ##
=============================================
- Coverage 43.16% 43.15% -0.01%
- Complexity 9007 9008 +1
=============================================
Files 1107 1107
Lines 78269 78269
Branches 10202 10202
=============================================
- Hits 33782 33778 -4
- Misses 40248 40250 +2
- Partials 4239 4241 +2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/rocketmq/client/common/ThreadLocalIndex.java](https://codecov.io/gh/apache/rocketmq/pull/6517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29tbW9uL1RocmVhZExvY2FsSW5kZXguamF2YQ==) | `100.00% <100.00%> (ø)` | |
... and [20 files with indirect coverage changes](https://codecov.io/gh/apache/rocketmq/pull/6517/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-code-scanning[bot] commented on pull request #6517: [ISSUE #6516] Remove redundant code from ThreadLocalIndex
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on PR #6517:
URL: https://github.com/apache/rocketmq/pull/6517#issuecomment-1498362516
You have successfully added a new CodeQL configuration `.github/workflows/codeql_analysis.yml:CodeQL-Build`. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository [Security tab](/apache/rocketmq/security/code-scanning?query=pr%3A6517+tool%3ACodeQL+is%3Aopen).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xuziyang commented on pull request #6517: [ISSUE #6516] Remove redundant code from ThreadLocalIndex
Posted by "xuziyang (via GitHub)" <gi...@apache.org>.
xuziyang commented on PR #6517:
URL: https://github.com/apache/rocketmq/pull/6517#issuecomment-1537781232
> @xuziyang ,The pr can be merged after the required checks have been passed,
>
> Please rebase develop
Already rebased, please execute workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xuziyang commented on pull request #6517: [ISSUE #6516] Remove redundant code from ThreadLocalIndex
Posted by "xuziyang (via GitHub)" <gi...@apache.org>.
xuziyang commented on PR #6517:
URL: https://github.com/apache/rocketmq/pull/6517#issuecomment-1537781783
Already rebased, please execute workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org