You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/30 01:36:51 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25292:
[SPARK-28556][SQL] QueryExecutionListener should also notify Error
HyukjinKwon commented on a change in pull request #25292: [SPARK-28556][SQL] QueryExecutionListener should also notify Error
URL: https://github.com/apache/spark/pull/25292#discussion_r308501742
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##########
@@ -58,12 +58,12 @@ trait QueryExecutionListener {
* @param funcName the name of the action that triggered this query.
* @param qe the QueryExecution object that carries detail information like logical plan,
* physical plan, etc.
- * @param exception the exception that failed this query.
+ * @param error the exception that failed this query.
*
* @note This can be invoked by multiple different threads.
*/
@DeveloperApi
- def onFailure(funcName: String, qe: QueryExecution, exception: Exception): Unit
+ def onFailure(funcName: String, qe: QueryExecution, error: Throwable): Unit
Review comment:
Yea, we should sort those problems out. There's another occurrence at Dataset.queryExecution as an API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org