You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by cdonati <gi...@git.apache.org> on 2017/11/17 18:49:42 UTC

[GitHub] zookeeper pull request #421: ZOOKEEPER-2944: Specify correct overflow value

GitHub user cdonati opened a pull request:

    https://github.com/apache/zookeeper/pull/421

    ZOOKEEPER-2944: Specify correct overflow value

    When a sequence counter exceeds 2147483647, the next value is -2147483648.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cdonati/zookeeper-1 ZOOKEEPER-2944

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #421
    
----
commit 5d054ba2dde2faad5dc3baaac129eb1028de16bf
Author: Chris Donati <ch...@appscale.com>
Date:   2017-11-17T18:34:57Z

    ZOOKEEPER-2944: Specify correct overflow value
    
    When a sequence counter exceeds 2147483647, the next value is
    -2147483648.

----


---

[GitHub] zookeeper pull request #421: ZOOKEEPER-2944: Specify correct overflow value

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/421


---

[GitHub] zookeeper issue #421: ZOOKEEPER-2944: Specify correct overflow value

Posted by phunt <gi...@git.apache.org>.

Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/421
  
    Throwing an exception sounds like a pretty reasonable thing to do, however it's probably client code dependent. Perhaps a note that this may (likely?) have to be handled as an error condition...
    
    I'll commit this in the mean time. Please feel free to followup with additional jiras as necessary/appropriate.
    
    Thanks!


---

[GitHub] zookeeper issue #421: ZOOKEEPER-2944: Specify correct overflow value

Posted by afine <gi...@git.apache.org>.

Github user afine commented on the issue:

    https://github.com/apache/zookeeper/pull/421
  
    I created ZOOKEEPER-2947 to track additional work in this area.


---