You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/26 20:49:36 UTC
[GitHub] [airflow] pauldalewilliams opened a new pull request, #26685: Fix intermittently failing tests for SFTPOperator
pauldalewilliams opened a new pull request, #26685:
URL: https://github.com/apache/airflow/pull/26685
Fixes SFTPOperator tests that are intermittently failing (see #26666 as an example)
I think more refactoring of these tests could be a good thing, but I'm not comfortable enough with testing yet to feel confident in making those changes. I believe the changes I made here keep the original tests as close to their current structure as possible while addressing the issues that cause them to fail intermittently (depending on side effects of previous tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26685: Fix intermittently failing tests for SFTPOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26685:
URL: https://github.com/apache/airflow/pull/26685#issuecomment-1258746849
> Edit: Forgot to mention I ran the tests locally 40 times to make sure this actually resolves the issues and all 40 runs were successful.
What a dedication :). Thanks a lot for those :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26685: Fix intermittently failing tests for SFTPOperator
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26685:
URL: https://github.com/apache/airflow/pull/26685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pauldalewilliams commented on pull request #26685: Fix intermittently failing tests for SFTPOperator
Posted by GitBox <gi...@apache.org>.
pauldalewilliams commented on PR #26685:
URL: https://github.com/apache/airflow/pull/26685#issuecomment-1258857799
> > Edit: Forgot to mention I ran the tests locally 40 times to make sure this actually resolves the issues and all 40 runs were successful.
>
> What a dedication :). Thanks a lot for those :)
Haha, it was the only way I felt I could be sure I wasn't just getting lucky! 10 times in a row seemed like it was good enough, but I did another 30 just to be sure. 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org