You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "gguptp (via GitHub)" <gi...@apache.org> on 2024/09/09 10:49:19 UTC
[PR] [FLINK-36239][Connectors/DynamoDB][BugFix] Making the shard retention period to 48h instead of 24h [flink-connector-aws]
gguptp opened a new pull request, #163:
URL: https://github.com/apache/flink-connector-aws/pull/163
<!--
*Thank you for contributing to Apache Flink AWS Connectors - we are happy that you want to help us improve our Flink connectors. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- The name of the pull request should correspond to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Commits should be in the form of "[FLINK-XXXX][component] Title of the pull request", where [FLINK-XXXX] should be replaced by the actual issue number.
Generally, [component] should be the connector you are working on.
For example: "[FLINK-XXXX][Connectors/Kinesis] XXXX" if you are working on the Kinesis connector or "[FLINK-XXXX][Connectors/AWS] XXXX" if you are working on components shared among all the connectors.
- Each pull request should only have one JIRA issue.
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
## Purpose of the change
Making the shard retention period to 48h instead of 24h
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is already covered by existing tests, such as *(please describe tests)*.
Unit tests already cover this change
## Significant changes
*(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)*
- [ ] Dependencies have been added or upgraded
- [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
- [ ] Serializers have been changed
- [ ] New feature has been introduced
- If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36239][Connectors/DynamoDB][BugFix] Making the shard retention period to 48h instead of 24h [flink-connector-aws]
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on code in PR #163:
URL: https://github.com/apache/flink-connector-aws/pull/163#discussion_r1750112355
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/util/ShardUtils.java:
##########
@@ -26,7 +26,10 @@
/** Utility methods for properties of DynamoDB streams shards. */
@Internal
public class ShardUtils {
- private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD = Duration.ofHours(25);
+ private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD = Duration.ofHours(48);
+
+ private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD_FOR_RESOLVING_INCONSISTENCIES =
Review Comment:
can we add a comment to explain why this is different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36239][Connectors/DynamoDB][BugFix] Making the shard retention period to 48h instead of 24h [flink-connector-aws]
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on code in PR #163:
URL: https://github.com/apache/flink-connector-aws/pull/163#discussion_r1750227732
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/util/ShardUtils.java:
##########
@@ -26,7 +26,10 @@
/** Utility methods for properties of DynamoDB streams shards. */
@Internal
public class ShardUtils {
- private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD = Duration.ofHours(25);
+ private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD = Duration.ofHours(48);
+
+ private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD_FOR_RESOLVING_INCONSISTENCIES =
Review Comment:
Thanks for adding the comment @gguptp , but can we add some explanation for why we chose these values? This is to serve as reasoning for future implementers why we chose these values.
e.g. we set this to be 25 hours because records in DDB stream are expired after 24 hours, so we don't need to resolve inconsistencies in those shards, as they will be deleted.
And for the `48` hours, maybe we can say that we allow DDB to allow DDB shards to remain after maximum retention period.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36239][Connectors/DynamoDB][BugFix] Making the shard retention period to 48h instead of 24h [flink-connector-aws]
Posted by "gguptp (via GitHub)" <gi...@apache.org>.
gguptp commented on code in PR #163:
URL: https://github.com/apache/flink-connector-aws/pull/163#discussion_r1750127391
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/util/ShardUtils.java:
##########
@@ -26,7 +26,10 @@
/** Utility methods for properties of DynamoDB streams shards. */
@Internal
public class ShardUtils {
- private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD = Duration.ofHours(25);
+ private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD = Duration.ofHours(48);
+
+ private static final Duration DDB_STREAMS_MAX_RETENTION_PERIOD_FOR_RESOLVING_INCONSISTENCIES =
Review Comment:
added comment for the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36239][Connectors/DynamoDB][BugFix] Making the shard retention period to 48h instead of 24h [flink-connector-aws]
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 merged PR #163:
URL: https://github.com/apache/flink-connector-aws/pull/163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org