You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2014/01/01 16:55:50 UTC
[jira] [Commented] (QPID-3868) Test
org.apache.qpid.server.queue.TimeToLiveTest.testActiveTTL fails very
occasionally on slow CI box.
[ https://issues.apache.org/jira/browse/QPID-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859898#comment-13859898 ]
Keith Wall commented on QPID-3868:
----------------------------------
We believe this was caused by a Broker defect in IncomingMessage.java. Its algorithm would leave expiration unset if System.currentTimeMillis() - timestamp == 0 which would account for the test failure described above.
{code}
- // todo perhaps use arrival time
- long diff = (System.currentTimeMillis() - timestamp);
-
- if ((diff > 1000L) || (diff < 1000L))
- {
- _expiration = expiration + diff;
- }
{code}
It was fixed by way of the changes made by QPID-4390 (rev 1447646). This was part of 0.22.
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/queue/IncomingMessage.java?limit_changes=0&r1=1447646&r2=1447645&pathrev=1447646
Marking as fixed by 0.22. Closing JIRA.
> Test org.apache.qpid.server.queue.TimeToLiveTest.testActiveTTL fails very occasionally on slow CI box.
> ------------------------------------------------------------------------------------------------------
>
> Key: QPID-3868
> URL: https://issues.apache.org/jira/browse/QPID-3868
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: 0.15, 0.19
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.22
>
> Attachments: TEST-org.apache.qpid.server.queue.TimeToLiveTest.testActiveTTL.out, TEST-org.apache.qpid.server.queue.TimeToLiveTest.testActiveTTL.out
>
>
> Test org.apache.qpid.server.queue.TimeToLiveTest.testActiveTTL occasionally seen to fail on the java-bdb.0-9-1 profile on a slow CI box.
> {code}
> junit.framework.AssertionFailedError: Messages not automatically expired: expected:<0> but was:<1>
> at org.apache.qpid.server.queue.TimeToLiveTest.testActiveTTL(TimeToLiveTest.java:207)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org