You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/10/03 09:16:00 UTC
[jira] [Commented] (AIRFLOW-1323) Operators related to Dataproc
should keep some parameters consistent
[ https://issues.apache.org/jira/browse/AIRFLOW-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189432#comment-16189432 ]
ASF subversion and git services commented on AIRFLOW-1323:
----------------------------------------------------------
Commit dd861f8cd0491f977ba545415d667f3d4611b5b8 in incubator-airflow's branch refs/heads/master from [~cjqian]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=dd861f8 ]
[AIRFLOW-1323] Made Dataproc operator parameter names consistent
Closes #2636 from cjqian/1323
> Operators related to Dataproc should keep some parameters consistent
> --------------------------------------------------------------------
>
> Key: AIRFLOW-1323
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1323
> Project: Apache Airflow
> Issue Type: Improvement
> Components: operators
> Reporter: Yu Ishikawa
> Assignee: Crystal Qian
> Priority: Minor
>
> The parameters of {{DataprocClusterDeleteOperator}} and {{DataprocClusterCreateOperator}} for GCP connection ID are {{google_cloud_conn_id}}. On the other hand, for example,
> {{DataProcPigOperator}}'s paramter is {{gcp_conn_id}}. I think this inconsistency may make users confused. We should keep the parameter's name consistent.
> For another example, parameters for a cluster name don't have consistency like {{cluster_name}} and {{dataproc_cluster}}.
> - https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L58
> - https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L626
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)