You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/06/30 05:32:01 UTC
[GitHub] trafficserver pull request #770: Integrate clang-tidy into the build.
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/770
Integrate clang-tidy into the build.
Add a recursive tidy rule to run clang-tidy over all the source.
The mor recommended way to do this is to build a compilation database,
however the tools for doing that are not very portable, and the
compilation database doesn't easilt let you fix code in header
files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/clang-tidy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/770.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #770
----
commit c4a67b4f33bc6ee745591837f173d93152d49da1
Author: James Peach <jp...@apache.org>
Date: 2016-06-28T05:38:35Z
Integrate clang-tidy into the build.
Add a recursive tidy rule to run clang-tidy over all the source.
The mor recommended way to do this is to build a compilation database,
however the tools for doing that are not very portable, and the
compilation database doesn't easilt let you fix code in header
files.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/770
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/293/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/770
Unless there's a penalty (or error) to always use $(sort ...), I'd recommend doing so consistently. That avoids future kids from having to know when, or when not to, use it.
Where is tidy.mk?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/770
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/397/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/770
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #770: Integrate clang-tidy into the build.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/770
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/770
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/387/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/770
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/396/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/770
@zwoop @PSUdaemon
Please take this for a spin, but let's not merge yet. It looks like ``clang-tidy`` still get various build errors which cause it to eat code in unfortunate ways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/770
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/283/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/770
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/292/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---