[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.

[GitBox <gi...@apache.org>]

sjanc commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1039423505


##########
nimble/host/include/host/ble_hs.h:
##########
@@ -184,6 +184,22 @@ extern "C" {
 
 /** CSRK distibution and LinkKey are not supported */
 
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
+#define NIMBLE_DEPRECATED(_msg) __attribute__((deprecated("Deprecated. Should not be used. " _msg)))

Review Comment:
   This should be the other way around... but I really think that this feature (warn on deprecate) should be opt in, ie  name it BLE_WARN_ON_DEPRECATE and default to 0 and warn only if it is set to 1



##########
nimble/host/include/host/ble_hs.h:
##########
@@ -184,6 +184,22 @@ extern "C" {
 
 /** CSRK distibution and LinkKey are not supported */
 
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)

Review Comment:
   this header should include #include "syscfg/syscfg.h if it is using MYNEWT_VAL() makro



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org