You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by em...@apache.org on 2019/06/24 14:14:56 UTC
[arrow] branch master updated: ARROW-5706: [Java] Remove type
conversion in getValidityBufferValueCapacity
This is an automated email from the ASF dual-hosted git repository.
emkornfield pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 596faf3 ARROW-5706: [Java] Remove type conversion in getValidityBufferValueCapacity
596faf3 is described below
commit 596faf34a6aa6ea5317f3adc72f1c2747a2db9b6
Author: tianchen <ni...@alibaba-inc.com>
AuthorDate: Mon Jun 24 07:12:11 2019 -0700
ARROW-5706: [Java] Remove type conversion in getValidityBufferValueCapacity
Related to [ARROW-5706](https://issues.apache.org/jira/browse/ARROW-5706).
Now implementation of getValidityBufferValueCapacity is:
(int) (validityBuffer.capacity() * 8L)
Seems no need to convert it to Long then convert it back to Int, just replace with:
validityBuffer.capacity() * 8
VariableWidthVectorBenchmarks#getValueCapacity shows the performance:
Before:
avgt 5 5.731 ± 0.160 ns/op
After:
avgt 5 5.124 ± 0.125 ns/op
Author: tianchen <ni...@alibaba-inc.com>
Closes #4672 from tianchen92/ARROW-5706 and squashes the following commits:
46ca22e25 <tianchen> Remove type conversion in getValidityBufferValueCapacity
---
.../src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java | 2 +-
.../src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java | 2 +-
java/vector/src/main/java/org/apache/arrow/vector/BitVector.java | 2 +-
.../main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java | 2 +-
.../src/main/java/org/apache/arrow/vector/complex/ListVector.java | 2 +-
.../src/main/java/org/apache/arrow/vector/complex/StructVector.java | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java b/java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java
index 3660096..91937ca 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java
@@ -175,7 +175,7 @@ public abstract class BaseFixedWidthVector extends BaseValueVector
}
private int getValidityBufferValueCapacity() {
- return (int) (validityBuffer.capacity() * 8L);
+ return validityBuffer.capacity() * 8;
}
/**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java b/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java
index eb99056..5491302 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java
@@ -208,7 +208,7 @@ public abstract class BaseVariableWidthVector extends BaseValueVector
}
private int getValidityBufferValueCapacity() {
- return (int) (validityBuffer.capacity() * 8L);
+ return validityBuffer.capacity() * 8;
}
private int getOffsetBufferValueCapacity() {
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/BitVector.java b/java/vector/src/main/java/org/apache/arrow/vector/BitVector.java
index 4fcf069..ebaca4e 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/BitVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/BitVector.java
@@ -106,7 +106,7 @@ public class BitVector extends BaseFixedWidthVector {
*/
@Override
public int getValueCapacity() {
- return (int) (validityBuffer.capacity() * 8L);
+ return validityBuffer.capacity() * 8;
}
/**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java
index ba935b3..35bede6 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java
@@ -444,7 +444,7 @@ public class FixedSizeListVector extends BaseValueVector implements FieldVector,
* current capacity.
*/
private int getValidityBufferValueCapacity() {
- return (int) (validityBuffer.capacity() * 8L);
+ return validityBuffer.capacity() * 8;
}
/**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
index 6945e91..bfbc5c7 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
@@ -704,7 +704,7 @@ public class ListVector extends BaseRepeatedValueVector implements FieldVector,
}
private int getValidityBufferValueCapacity() {
- return (int) (validityBuffer.capacity() * 8L);
+ return validityBuffer.capacity() * 8;
}
/**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java
index fddd149..35f50ef 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java
@@ -257,7 +257,7 @@ public class StructVector extends NonNullableStructVector implements FieldVector
* @return number of elements that validity buffer can hold
*/
private int getValidityBufferValueCapacity() {
- return (int) (validityBuffer.capacity() * 8L);
+ return validityBuffer.capacity() * 8;
}
/**