You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2026/02/09 15:42:57 UTC
[PR] [Fix](search) fix multi-field lucene best_fields grouping [doris]
airborne12 opened a new pull request, #60626:
URL: https://github.com/apache/doris/pull/60626
### What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary:
- Fixes multi-field `search()` parsing/rewriting in `mode=lucene` where `best_fields` lost boolean grouping and produced incorrect query behavior.
- Refactors parser flow for bare-query handling and multi-field expansion so `best_fields` and `cross_fields` keep their intended semantics.
- Resolves regression failure in `search/test_search_multi_field.groovy` (`multi_field_best_fields_lucene`).
### Release note
Fix `search()` multi-field lucene `best_fields` boolean grouping semantics.
### Check List (For Author)
- Test
- [x] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [ ] No.
- [x] Yes. Restores expected boolean grouping behavior for `search()` in multi-field lucene `best_fields` mode.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](search) fix multi-field lucene best_fields grouping [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60626:
URL: https://github.com/apache/doris/pull/60626#issuecomment-3874873923
<details>
<summary>ClickBench: <b>Total hot run time: 28.5 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 40615b8427fdd36710c9d097aa56252a425f2822, data reload: false
query1 0.06 0.05 0.05
query2 0.10 0.05 0.05
query3 0.26 0.08 0.09
query4 1.60 0.10 0.11
query5 0.26 0.24 0.25
query6 1.17 0.68 0.66
query7 0.03 0.03 0.02
query8 0.05 0.04 0.04
query9 0.56 0.50 0.49
query10 0.56 0.55 0.54
query11 0.15 0.10 0.10
query12 0.16 0.10 0.11
query13 0.62 0.62 0.61
query14 1.08 1.07 1.05
query15 0.88 0.85 0.87
query16 0.39 0.39 0.41
query17 1.10 1.15 1.08
query18 0.23 0.21 0.21
query19 2.05 1.99 2.00
query20 0.02 0.01 0.01
query21 15.44 0.25 0.15
query22 5.25 0.06 0.06
query23 16.14 0.27 0.11
query24 1.31 0.40 0.44
query25 0.12 0.12 0.06
query26 0.15 0.14 0.14
query27 0.06 0.06 0.06
query28 3.99 1.16 0.98
query29 12.55 3.86 3.21
query30 0.28 0.14 0.12
query31 2.82 0.64 0.40
query32 3.23 0.60 0.49
query33 3.18 3.31 3.30
query34 16.39 5.35 4.71
query35 4.74 4.81 4.76
query36 0.67 0.50 0.50
query37 0.11 0.07 0.07
query38 0.08 0.04 0.04
query39 0.05 0.03 0.03
query40 0.19 0.17 0.16
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 98.25 s
Total hot run time: 28.5 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](search) fix multi-field lucene best_fields grouping [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 closed pull request #60626: [Fix](search) fix multi-field lucene best_fields grouping
URL: https://github.com/apache/doris/pull/60626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](search) fix multi-field lucene best_fields grouping [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60626:
URL: https://github.com/apache/doris/pull/60626#issuecomment-3872511386
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](search) fix multi-field lucene best_fields grouping [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60626:
URL: https://github.com/apache/doris/pull/60626#issuecomment-3874932392
# FE UT Coverage Report
Increment line coverage ` 66.67% (174/261)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60626_40615b8427fdd36710c9d097aa56252a425f2822/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60626_40615b8427fdd36710c9d097aa56252a425f2822/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](search) fix multi-field lucene best_fields grouping [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #60626:
URL: https://github.com/apache/doris/pull/60626#issuecomment-3874725606
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](search) fix multi-field lucene best_fields grouping [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60626:
URL: https://github.com/apache/doris/pull/60626#issuecomment-3874831056
<details>
<summary>TPC-H: <b>Total hot run time: 30569 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 40615b8427fdd36710c9d097aa56252a425f2822, data reload: false
------ Round 1 ----------------------------------
q1 17574 4491 4311 4311
q2 2014 347 236 236
q3 10163 1271 733 733
q4 10197 775 309 309
q5 7506 2234 1920 1920
q6 193 176 144 144
q7 906 739 612 612
q8 9279 1348 1019 1019
q9 4566 4647 4679 4647
q10 6802 1960 1553 1553
q11 524 313 292 292
q12 340 371 229 229
q13 17772 4022 3195 3195
q14 227 241 217 217
q15 878 805 821 805
q16 678 681 621 621
q17 700 817 511 511
q18 6545 5880 6054 5880
q19 1207 1117 649 649
q20 534 519 420 420
q21 2711 1983 2014 1983
q22 396 331 283 283
Total cold run time: 101712 ms
Total hot run time: 30569 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4598 4760 4647 4647
q2 258 345 266 266
q3 2328 2912 2504 2504
q4 1591 1980 1482 1482
q5 4871 4769 4906 4769
q6 228 180 140 140
q7 2084 1921 1806 1806
q8 2614 2365 2382 2365
q9 7471 7418 7476 7418
q10 2821 2937 2632 2632
q11 555 519 471 471
q12 689 741 583 583
q13 3562 4025 3186 3186
q14 268 281 264 264
q15 820 783 769 769
q16 632 677 626 626
q17 1073 1267 1283 1267
q18 7376 7496 7283 7283
q19 836 756 775 756
q20 1964 2008 1876 1876
q21 4503 4141 4117 4117
q22 552 535 487 487
Total cold run time: 51694 ms
Total hot run time: 49714 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org