You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2024/03/06 09:55:14 UTC
[PR] GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests [arrow]
jorisvandenbossche opened a new pull request, #40381:
URL: https://github.com/apache/arrow/pull/40381
### Rationale for this change
Fixing the hypothesis tests:
- fixup untested changes to the strategies from https://github.com/apache/arrow/pull/40160
- fix a bug in the `byte_width` attribute discovered by hypothesis (introduced by https://github.com/apache/arrow/pull/40160)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #40381:
URL: https://github.com/apache/arrow/pull/40381#issuecomment-1980490643
@github-actions crossbow submit test-conda-python-3.11-hypothesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40381:
URL: https://github.com/apache/arrow/pull/40381#issuecomment-1980494643
Revision: 982866a604f45f3151f7a4086a762081c58532fa
Submitted crossbow builds: [ursacomputing/crossbow @ actions-fd63f80e3a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-fd63f80e3a)
|Task|Status|
|----|------|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/8170144527/job/22335678043)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #40381:
URL: https://github.com/apache/arrow/pull/40381#issuecomment-1983228732
@github-actions crossbow submit *hypothesis*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40381:
URL: https://github.com/apache/arrow/pull/40381#issuecomment-1983235864
Revision: 13eb29fd0f0a1bcd2f060237e8558332f40ab432
Submitted crossbow builds: [ursacomputing/crossbow @ actions-88ac61f97a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-88ac61f97a)
|Task|Status|
|----|------|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/8186795743/job/22385909856)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40381:
URL: https://github.com/apache/arrow/pull/40381#issuecomment-1980490037
:warning: GitHub issue #40379 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40381:
URL: https://github.com/apache/arrow/pull/40381#issuecomment-1983801295
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit ed5e1b4166c8d8984a3d01a6a14b939e9a4c8ce4.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/22398948014) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #40381:
URL: https://github.com/apache/arrow/pull/40381#discussion_r1514176368
##########
python/pyarrow/tests/strategies.py:
##########
@@ -322,6 +322,10 @@ def arrays(draw, type, size=None, nullable=True):
value = _pylist(ty.value_type, size=size, nullable=nullable)
elif pa.types.is_fixed_size_list(ty):
value = _pylist(ty.value_type, size=ty.list_size, nullable=nullable)
+ elif pa.types.is_list_view(ty):
+ value = _pylist(ty.value_type, size=size, nullable=nullable)
+ elif pa.types.is_large_list_view(ty):
+ value = _pylist(ty.value_type, size=size, nullable=nullable)
Review Comment:
Do we want to create issues to add REE and StringView support as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #40381:
URL: https://github.com/apache/arrow/pull/40381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org