You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/10/14 15:02:14 UTC
[GitHub] [fluo-uno] jmark99 opened a new pull request #260: Allow use of Hadoop 3.x with Accumulo 1.10.x in uno.conf
jmark99 opened a new pull request #260:
URL: https://github.com/apache/fluo-uno/pull/260
Update uno.conf version sanity check to allow Hadoop 3.x to be used with Accumulo versions 1.10 and greater.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-uno] jmark99 commented on a change in pull request #260: Allow use of Hadoop 3.x with Accumulo 1.10.x in uno.conf
Posted by GitBox <gi...@apache.org>.
jmark99 commented on a change in pull request #260:
URL: https://github.com/apache/fluo-uno/pull/260#discussion_r504915867
##########
File path: conf/uno.conf
##########
@@ -102,8 +102,8 @@ if [[ "${HADOOP_VERSION}" = 1.* ]]; then
exit 1
fi
-if [[ -z "$ACCUMULO_REPO" && "${ACCUMULO_VERSION}" = 1.* && ! "${HADOOP_VERSION}" = 2.* ]]; then
- echo "ERROR from uno.conf : When using Accumulo 1.x, expect Hadoop 2.x not $HADOOP_VERSION" 1>&2
+if [[ -z "$ACCUMULO_REPO" && "${ACCUMULO_VERSION}" =~ ^1\.[[:digit:]]\.[[:digit:]]+$ && ! "${HADOOP_VERSION}" = 2.* ]]; then
Review comment:
I updated to add the changes if you'd like to merge. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-uno] ctubbsii commented on a change in pull request #260: Allow use of Hadoop 3.x with Accumulo 1.10.x in uno.conf
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #260:
URL: https://github.com/apache/fluo-uno/pull/260#discussion_r504831777
##########
File path: conf/uno.conf
##########
@@ -102,8 +102,8 @@ if [[ "${HADOOP_VERSION}" = 1.* ]]; then
exit 1
fi
-if [[ -z "$ACCUMULO_REPO" && "${ACCUMULO_VERSION}" = 1.* && ! "${HADOOP_VERSION}" = 2.* ]]; then
- echo "ERROR from uno.conf : When using Accumulo 1.x, expect Hadoop 2.x not $HADOOP_VERSION" 1>&2
+if [[ -z "$ACCUMULO_REPO" && "${ACCUMULO_VERSION}" =~ ^1\.[[:digit:]]\.[[:digit:]]+$ && ! "${HADOOP_VERSION}" = 2.* ]]; then
Review comment:
Can remove unnecessary quotes/braces, and `[0-9]` is a shorter way of matching digits, and `[.]` matches a dot without a backslash (because backslashes are annoying, especially when they get nested inside strings and you have multiple escape character layers).
```suggestion
if [[ -z $ACCUMULO_REPO && $ACCUMULO_VERSION =~ ^1[.][0-9][.][0-9]+$ && ! $HADOOP_VERSION = 2.* ]]; then
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-uno] ctubbsii merged pull request #260: Allow use of Hadoop 3.x with Accumulo 1.10.x in uno.conf
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #260:
URL: https://github.com/apache/fluo-uno/pull/260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org