You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Thom May <th...@planetarytramp.net> on 2002/02/23 00:15:03 UTC

[PATCH] Pass all revelant build variables to sub-builds

Hi,
when configuring apache2 using a layout, the necessary variables are not
passed to the configure processes for apr, apr-util and pcre.
This is a patch to correct this:
It moves the parsing of the layout to before the configure processes for
srclib starts, and it passes more variables to the child configures.
Cheers,
-Thom
-- 
Thom May	 || [...] and the French an excuse to use their traditional 
thom@debian.org	 || battle cry. -- Firebeard 
+44(0)7736773209 || "We Surrender, here, have my daughter."? -- Paul Tomblin


--- configure.in.orig	Fri Feb  1 23:22:29 2002
+++ configure.in	Fri Feb 22 23:08:30 2002
@@ -41,6 +41,10 @@
 test "$prefix" = "NONE" && prefix='/usr/local/apache2'
 test "$exec_prefix" = "NONE" && exec_prefix='${prefix}'
 
+dnl Get the layout here, so we can pass the required variables to apr
+APACHE_ENABLE_LAYOUT
+
+
 dnl ## Run configure for packages Apache uses
 
 dnl shared library support for these packages doesn't currently
@@ -52,15 +56,15 @@
 
 echo $ac_n "${nl}Configuring Apache Portable Runtime library ...${nl}"
 
-APR_SUBDIR_CONFIG(srclib/apr, "$apache_apr_flags --prefix=$prefix")
+APR_SUBDIR_CONFIG(srclib/apr, "$apache_apr_flags --prefix=$prefix --exec-prefix=$exec_prefix --libdir=$libdir --bindir=$bindir")
 
 echo $ac_n "${nl}Configuring Apache Portable Runtime Utility library...${nl}"
 
-APR_SUBDIR_CONFIG(srclib/apr-util, "--with-apr=../apr --prefix=$prefix")
+APR_SUBDIR_CONFIG(srclib/apr-util, "--with-apr=../apr --prefix=$prefix --exec-prefix=$exec_prefix --libdir=$libdir --bindir=$bindir")
 
 echo $ac_n "${nl}Configuring PCRE regular expression library ...${nl}"
 
-APR_SUBDIR_CONFIG(srclib/pcre, "--prefix=$prefix")
+APR_SUBDIR_CONFIG(srclib/pcre, "--prefix=$prefix --exec-prefix=$exec_prefix --libdir=$libdir --bindir=$bindir")
 
 echo $ac_n "${nl}Configuring Apache httpd ...${nl}"
 
@@ -277,7 +281,6 @@
   APR_ADDTO(CPPFLAGS, -DAP_DEBUG)
 ])dnl
 
-APACHE_ENABLE_LAYOUT
 prefix="$orig_prefix"
 APACHE_ENABLE_MODULES

Re: [PATCH] Pass all revelant build variables to sub-builds

Posted by Thom May <th...@planetarytramp.net>.
* Thom May (thom@planetarytramp.net) wrote :
> Hi,
> when configuring apache2 using a layout, the necessary variables are not
> passed to the configure processes for apr, apr-util and pcre.
> This is a patch to correct this:
> It moves the parsing of the layout to before the configure processes for
> srclib starts, and it passes more variables to the child configures.

After some testing on OSes with nasty sh implementations (Solaris)
this causes some problems. The problem is that if one of the variables
passed is in the for $variable/dir, this gets changed to $(variable)/dir
before it's passed to the child configure. This causes the error:
./configure: syntax error at line 1: `(' unexpected

Thanks to Aaron for spotting this.
I'm working on finding a solution for this now.
Cheers,
-Thom