You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Joe Orton <jo...@redhat.com> on 2012/01/18 11:39:31 UTC
Re: svn commit: r1232575 - /httpd/httpd/trunk/configure.in
On Tue, Jan 17, 2012 at 09:12:19PM -0000, Graham Leggett wrote:
...
> @@ -88,6 +96,9 @@ if test "$apr_found" = "no"; then
> fi
>
> if test "$apr_found" = "reconfig"; then
> + if test ! -d srclib/apr; then
> + AC_MSG_ERROR([Bundled APR requested but not found at srclib/apr. Download and unpack the corresponding httpd-${HTTPD_VERSION}-deps package over this one.])
> + fi
It looks like that breaks srcdir!=builddir builds, srclib/apr need not
exist in $builddir, APR_SUBDIR_CONFIG will create it as necessary. The
right place for that check would be higher up,
if test "x$with_included_apr" = "xyes"; then
apr_found=reconfig
#### <<< here >>>
else
...
since in the "else" case, APR_FIND_APR already checks for existence of
$srcdir/srclib/apr.
Regards, Joe
Re: svn commit: r1232575 - /httpd/httpd/trunk/configure.in
Posted by Graham Leggett <mi...@sharp.fm>.
On 18 Jan 2012, at 12:39 PM, Joe Orton wrote:
> It looks like that breaks srcdir!=builddir builds, srclib/apr need not
> exist in $builddir, APR_SUBDIR_CONFIG will create it as necessary. The
> right place for that check would be higher up,
>
> if test "x$with_included_apr" = "xyes"; then
> apr_found=reconfig
> #### <<< here >>>
> else
> ...
>
> since in the "else" case, APR_FIND_APR already checks for existence of
> $srcdir/srclib/apr.
Does r1232838 make more sense?
Regards,
Graham
--