robertzych commented on issue #11272:
URL: https://github.com/apache/pinot/issues/11272#issuecomment-1793195299
@walterddr Here's a summary of the topics that we'd like to get community feedback on:
1. Should we continue to de-dup the plan by using "Subtree Omitted" or include all sending hosts on the same line? See examples below.
Subtree Omitted:
```
EXPLAIN IMPLEMENTATION PLAN EXCLUDING ATTRIBUTES FOR SELECT col1, COUNT(*) FROM a GROUP BY col1
[0]@localhost:3 MAIL_RECEIVE(BROADCAST_DISTRIBUTED) [col1(STRING),$f1(LONG)]
├── [1]@localhost:1 MAIL_SEND(BROADCAST_DISTRIBUTED) [col1(STRING),$f1(LONG)]->{[0]@localhost@{3,3}|[0]} (Subtree Omitted)
└── [1]@localhost:2 MAIL_SEND(BROADCAST_DISTRIBUTED) [col1(STRING),$f1(LONG)]->{[0]@localhost@{3,3}|[0]}
└── [1]@localhost:2 AGGREGATE_FINAL [col1(STRING),$f1(LONG)]
└── [1]@localhost:2 MAIL_RECEIVE(HASH_DISTRIBUTED) [col1(STRING),$f1(LONG)]
├── [2]@localhost:1 MAIL_SEND(HASH_DISTRIBUTED) [col1(STRING),$f1(LONG)]->{[1]@localhost@{1,1}|[1],[1]@localhost@{2,2}|[0]} (Subtree Omitted)
└── [2]@localhost:2 MAIL_SEND(HASH_DISTRIBUTED) [col1(STRING),$f1(LONG)]->{[1]@localhost@{1,1}|[1],[1]@localhost@{2,2}|[0]}
└── [2]@localhost:2 AGGREGATE_LEAF [col1(STRING),$f1(LONG)]
└── [2]@localhost:2 TABLE SCAN (a) [col1(STRING),col2(STRING),col3(INT),col4(BIG_DECIMAL),col5(BOOLEAN),col6(INT),ts(LONG)]
```
All sending hosts on the same line:
```
EXPLAIN IMPLEMENTATION PLAN EXCLUDING ATTRIBUTES FOR SELECT col1, COUNT(*) FROM a GROUP BY col1
[0]@localhost:3 MAIL_RECEIVE(BROADCAST_DISTRIBUTED) [col1(STRING),$f1(LONG)]
└── [1]@{localhost:1,localhost:2} MAIL_SEND(BROADCAST_DISTRIBUTED) [col1(STRING),$f1(LONG)]->{[0]@localhost@{3,3}|[0]}
└── [1]@{localhost:1,localhost:2} AGGREGATE_FINAL [col1(STRING),$f1(LONG)]
└── [1]{localhost:1,localhost:2} MAIL_RECEIVE(HASH_DISTRIBUTED) [col1(STRING),$f1(LONG)]
└── [2]@{localhost:1,localhost:2} MAIL_SEND(HASH_DISTRIBUTED) [col1(STRING),$f1(LONG)]->{[1]@localhost@{1,1}|[1],[1]@localhost@{2,2}|[0]}
└── [2]@{localhost:1,localhost:2} AGGREGATE_LEAF [col1(STRING),$f1(LONG)]
└── [2]@{localhost:1,localhost:2} TABLE SCAN (a) [col1(STRING),col2(STRING),col3(INT),col4(BIG_DECIMAL),col5(BOOLEAN),col6(INT),ts(LONG)]
```
2. Should mailbox send/receive pairs share indentation levels?
3. Should we ensure all column names and types are listed in each node (eg `[col1(STRING),$f1(LONG)]`)?
4. Are references like $f1 acceptable, or must they include the original name (eg count)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org