You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/05/18 19:54:47 UTC
[jira] [Created] (HADOOP-7300) Configuration methods that return
collections are inconsistent about mutability
Configuration methods that return collections are inconsistent about mutability
-------------------------------------------------------------------------------
Key: HADOOP-7300
URL: https://issues.apache.org/jira/browse/HADOOP-7300
Project: Hadoop Common
Issue Type: Bug
Components: conf
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Fix For: 0.22.0
Attachments: hadoop-7300.txt
In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.
IMO we should always return mutable collections since these methods by definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7300) Configuration methods that return
collections are inconsistent about mutability
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7300:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk and 0.22. Thanks for the quick review, Chris!
> Configuration methods that return collections are inconsistent about mutability
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7300
> URL: https://issues.apache.org/jira/browse/HADOOP-7300
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7300) Configuration methods that return
collections are inconsistent about mutability
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035573#comment-13035573 ]
Hudson commented on HADOOP-7300:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #607 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/607/])
HADOOP-7300. Configuration methods that return collections are inconsistent about mutability. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124368
Files :
* /hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/src/java/org/apache/hadoop/util/StringUtils.java
> Configuration methods that return collections are inconsistent about mutability
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7300
> URL: https://issues.apache.org/jira/browse/HADOOP-7300
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7300) Configuration methods that return
collections are inconsistent about mutability
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035535#comment-13035535 ]
Chris Douglas commented on HADOOP-7300:
---------------------------------------
+1
> Configuration methods that return collections are inconsistent about mutability
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7300
> URL: https://issues.apache.org/jira/browse/HADOOP-7300
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7300) Configuration methods that return
collections are inconsistent about mutability
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7300:
--------------------------------
Status: Patch Available (was: Open)
> Configuration methods that return collections are inconsistent about mutability
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7300
> URL: https://issues.apache.org/jira/browse/HADOOP-7300
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7300) Configuration methods that return
collections are inconsistent about mutability
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7300:
--------------------------------
Attachment: hadoop-7300.txt
> Configuration methods that return collections are inconsistent about mutability
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7300
> URL: https://issues.apache.org/jira/browse/HADOOP-7300
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7300) Configuration methods that return
collections are inconsistent about mutability
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035708#comment-13035708 ]
Hudson commented on HADOOP-7300:
--------------------------------
Integrated in Hadoop-Common-22-branch #51 (See [https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/51/])
HADOOP-7300. Configuration methods that return collections are inconsistent about mutability. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124370
Files :
* /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/branches/branch-0.22/CHANGES.txt
* /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/conf/Configuration.java
> Configuration methods that return collections are inconsistent about mutability
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7300
> URL: https://issues.apache.org/jira/browse/HADOOP-7300
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7300) Configuration methods that return
collections are inconsistent about mutability
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035548#comment-13035548 ]
Hadoop QA commented on HADOOP-7300:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479625/hadoop-7300.txt
against trunk revision 1104426.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//console
This message is automatically generated.
> Configuration methods that return collections are inconsistent about mutability
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7300
> URL: https://issues.apache.org/jira/browse/HADOOP-7300
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7300) Configuration methods that return
collections are inconsistent about mutability
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036179#comment-13036179 ]
Hudson commented on HADOOP-7300:
--------------------------------
Integrated in Hadoop-Common-trunk #693 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk/693/])
HADOOP-7300. Configuration methods that return collections are inconsistent about mutability. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124368
Files :
* /hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/src/java/org/apache/hadoop/util/StringUtils.java
> Configuration methods that return collections are inconsistent about mutability
> -------------------------------------------------------------------------------
>
> Key: HADOOP-7300
> URL: https://issues.apache.org/jira/browse/HADOOP-7300
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by definition are doing copies.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira