You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/03 14:01:29 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #11298: ARROW-14205: [C++] Add unicode normalization to scalar string

pitrou commented on a change in pull request #11298:
URL: https://github.com/apache/arrow/pull/11298#discussion_r741969066



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -395,6 +399,17 @@ struct ARROW_EXPORT WeekOptions : public FunctionOptions {
   bool first_week_is_fully_in_year;
 };
 
+struct ARROW_EXPORT Utf8NormalizeOptions : public FunctionOptions {

Review comment:
       Actually, we shouldn't expose different ABIs depending on macro definitions, so I think this is fine. Calling the function will just error out at runtime, but there won't be any compile errors if some reason the installed Arrow version didn't enable utf8proc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org