[jira] [Commented] (ZOOKEEPER-1583) Document maxClientCnxns in conf/zoo_sample.cfg

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497394#comment-13497394 ] 

Hadoop QA commented on ZOOKEEPER-1583:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12553529/ZOOKEEPER-1583-1.patch
  against trunk revision 1404288.

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1262//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1262//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1262//console

This message is automatically generated.
                
> Document maxClientCnxns in conf/zoo_sample.cfg
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-1583
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1583
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 3.4.4
>            Reporter: Christopher Tubbs
>            Priority: Critical
>              Labels: configuration, documentation, example
>         Attachments: ZOOKEEPER-1583-1.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> It is silly that maxClientCnxns being set to the default, and that default being too low, is the number one issue for users (according to some: https://raw.github.com/strangeloop/strangeloop2012/master/slides/sessions/Ting-BuildingAnImpenetrableZooKeeper.pdf).
> It seems to me that this can be resolved by an extremely simple documentation change: add a commented-out configuration line in conf/zoo_sample.cfg that shows the default, but more importantly, shows users that the configuration option exists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira