You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/18 12:37:19 UTC
[GitHub] [spark] javierivanov opened a new pull request #26937:
[WIP][SPARK-30295][SQL]
javierivanov opened a new pull request #26937: [WIP][SPARK-30295][SQL]
URL: https://github.com/apache/spark/pull/26937
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
- Removed Hive dependencies from:
- SparkSQLCLIDriver
- SparkSQLDriver
- Added a SparkSQLCLIArguments
- Added new prompt string "spark-sql ($database)>"
- Added same showString method from Datasets to print String formatted results.
- At the moment this new implementation is missing:
- Some code documentation.
- Improved Console usage.
- Interruption Handling.
- IO handling for reading and writtig streams, currently using prinln.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To remove unnecessary hive dependencies for the Spark SQL Client.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Current tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] javierivanov commented on issue #26937: [SPARK-30295][SQL]
Replacing java code with Scala implementations in the Spark-sql cli
Posted by GitBox <gi...@apache.org>.
javierivanov commented on issue #26937: [SPARK-30295][SQL] Replacing java code with Scala implementations in the Spark-sql cli
URL: https://github.com/apache/spark/pull/26937#issuecomment-575275800
> Is the TL;DR here that you are inlining some Hive code so as to not depend on it? while I can see the value of reducing dependencies, does this much help much?
@srowen By removing hive dependencies where it is not needed, it is a step forward to reduce the footprint of the code and to maybe have a future version of the thrift module without Hive deps. at all. It also adds maintainability since Java collections were replaced with scala ones and some procedures were divided to simplify the reading. Also, as a side effect fixes SPARK-30049.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #26937: [SPARK-30295][SQL]
Replacing java code with Scala implementations in the Spark-sql cli
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #26937: [SPARK-30295][SQL] Replacing java code with Scala implementations in the Spark-sql cli
URL: https://github.com/apache/spark/pull/26937#issuecomment-575415538
Maybe @wangyum would be better to comment.
While I agree with the goal, this doesn't sever the connection to Hive. I'm also not clear why some Spark Scala code was rewritten here. How much are we sure the Hive code that was rewritten is equivalent and will remain so? maybe not a huge risk, but, I just don't know how much this buys vs the stated goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] javierivanov commented on issue #26937: [SPARK-30295][SQL]
Replacing java code with Scala implementations in the Spark-sql cli
Posted by GitBox <gi...@apache.org>.
javierivanov commented on issue #26937: [SPARK-30295][SQL] Replacing java code with Scala implementations in the Spark-sql cli
URL: https://github.com/apache/spark/pull/26937#issuecomment-574950643
Hey @HyukjinKwon , @dongjoon-hyun any thoughts for this PR? Please, let me know. Thanks :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] javierivanov closed pull request #26937: [SPARK-30295][SQL]
Replacing java code with Scala implementations in the Spark-sql cli
Posted by GitBox <gi...@apache.org>.
javierivanov closed pull request #26937: [SPARK-30295][SQL] Replacing java code with Scala implementations in the Spark-sql cli
URL: https://github.com/apache/spark/pull/26937
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #26937: [SPARK-30295][SQL]
Replacing java code with Scala implementations in the Spark-sql cli
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #26937: [SPARK-30295][SQL] Replacing java code with Scala implementations in the Spark-sql cli
URL: https://github.com/apache/spark/pull/26937#issuecomment-575181738
Is the TL;DR here that you are inlining some Hive code so as to not depend on it? while I can see the value of reducing dependencies, does this much help much?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org