You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2021/01/27 02:14:39 UTC

[Impala-ASF-CR] IMPALA-10382: fix invalid outer join simplification

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16845 )

Change subject: IMPALA-10382: fix invalid outer join simplification
......................................................................


Patch Set 2:

(1 comment)

Looks good to me except for a typo

http://gerrit.cloudera.org:8080/#/c/16845/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/16845/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3368
PS2, Line 3368: Builin
nit: Builtin



-- 
To view, visit http://gerrit.cloudera.org:8080/16845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a3812f4212fa823f3d1ced6e12f2df05aedb2b
Gerrit-Change-Number: 16845
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jan 2021 02:14:39 +0000
Gerrit-HasComments: Yes