[GitHub] [spark] itholic commented on a diff in pull request #39820: [SPARK-42249][SQL] Refining html link for documentation in error messages.

["itholic (via GitHub)" <gi...@apache.org>]

itholic commented on code in PR #39820:
URL: https://github.com/apache/spark/pull/39820#discussion_r1095625542


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -496,7 +496,7 @@
   },
   "ENCODER_NOT_FOUND" : {
     "message" : [
-      "Not found an encoder of the type <typeName> to Spark SQL internal representation. Consider to change the input type to one of supported at https://spark.apache.org/docs/latest/sql-ref-datatypes.html."
+      "Not found an encoder of the type <typeName> to Spark SQL internal representation. Consider to change the input type to one of supported at '<docroot>/sql-ref-datatypes.html'."

Review Comment:
   I just mimic the behavior of the existing error messages.
   
   e.g.
   ```json
     "WRONG_NUM_ARGS" : {
       "message" : [
         "The <functionName> requires <expectedNum> parameters but the actual number is <actualNum>."
       ],
       "subClass" : {
         "WITHOUT_SUGGESTION" : {
           "message" : [
             "Please, refer to 'https://spark.apache.org/docs/latest/sql-ref-functions.html' for a fix."
           ]
         },
   ```
   
   Do we want to just remove the '' ??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org