You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/08 15:08:17 UTC
[GitHub] [airflow] alexnu opened a new pull request #7102: [AIRFLOW-6510] -
Fix Druid operator rendering from file
alexnu opened a new pull request #7102: [AIRFLOW-6510] - Fix Druid operator rendering from file
URL: https://github.com/apache/airflow/pull/7102
Dear maintainers,
Please accept my PR which fixes the way druid specification json is loaded by leveraging template fields as in most other operators, rather that manually parsing the file in the operator.
I am also working on providing a valid unit test.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7102: [AIRFLOW-6510] - Fix
Druid operator rendering from file
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7102: [AIRFLOW-6510] - Fix Druid operator rendering from file
URL: https://github.com/apache/airflow/pull/7102#issuecomment-572631899
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7102?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@2754427`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/airflow/pull/7102?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7102 +/- ##
=========================================
Coverage ? 84.95%
=========================================
Files ? 682
Lines ? 39043
Branches ? 0
=========================================
Hits ? 33168
Misses ? 5875
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7102?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/operators/druid\_operator.py](https://codecov.io/gh/apache/airflow/pull/7102/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kcnVpZF9vcGVyYXRvci5weQ==) | `82.35% <50%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7102?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7102?src=pr&el=footer). Last update [2754427...17e0197](https://codecov.io/gh/apache/airflow/pull/7102?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7102:
[AIRFLOW-6510] - Fix Druid operator rendering from file
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7102: [AIRFLOW-6510] - Fix Druid operator rendering from file
URL: https://github.com/apache/airflow/pull/7102#issuecomment-572111740
Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory).
Adding a new operator? Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing
locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from
Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] alexnu closed pull request #7102: [AIRFLOW-6510] - Fix
Druid operator rendering from file
Posted by GitBox <gi...@apache.org>.
alexnu closed pull request #7102: [AIRFLOW-6510] - Fix Druid operator rendering from file
URL: https://github.com/apache/airflow/pull/7102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services